Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive error on sass variables and on custom properties #136

Closed
Semigradsky opened this issue Nov 17, 2020 · 4 comments
Closed

False positive error on sass variables and on custom properties #136

Semigradsky opened this issue Nov 17, 2020 · 4 comments

Comments

@Semigradsky
Copy link

.browserslistrc:

> 1%
not IE 11

Code example:

:root {
  $column-count: 3; // error

  --column-count: 3; // error
}

Errors:

Unexpected browser feature "multicolumn" is only partially supported by Edge 86, Firefox 81, Chrome 85,86, Chrome for Android 86 (plugin/no-unsupported-browser-features)

@Semigradsky
Copy link
Author

Looks like it is one of common edge-case =)

@Semigradsky
Copy link
Author

Semigradsky commented Nov 17, 2020

Doiuse and this plugin are only compatible with standard css syntax, so syntaxes like scss, less and others aren't supported.

Sorry, I didn't pay attention to this notice. In any case 'custom properties' is standard css syntax.

Looks like it related to anandthakker/doiuse#100 and anandthakker/doiuse#82

@ismay
Copy link
Collaborator

ismay commented Nov 17, 2020

Hi, thanks for the issue. Yes, this plugin only supports vanilla css, so it's possible it behaves incorrectly with sass.

And you're right, custom properties are standard syntax. Doiuse, the library that this plugin uses for detecting css support, is the lib responsible for the actual detecting of support. This plugin only wraps it.

The false positive for css variables is a known issue: anandthakker/doiuse#82. If you want to fix this or discuss it then the doiuse repo is the place to do it :). Hope that helps! I'll close this since there isn't anything I can do about it from this lib.

@ismay ismay closed this as completed Nov 17, 2020
@ismay
Copy link
Collaborator

ismay commented Nov 17, 2020

See also this comment, which explains the above in a bit more detail (though it's also partially about another topic): #45 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants