ComparisonOperator is a required field. so no need to handle it at query

ananthakumaran · Aug 18, 2014 · 5187af1 · 5187af1
1 parent c748a30
commit 5187af1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/fake_dynamo/validation.rb b/lib/fake_dynamo/validation.rb
@@ -214,10 +214,6 @@ def validate_range_condition(condition, schema)
     end
 
     def validate_conditions(conditions)
-      if conditions.any? { |_, v| !v['ComparisonOperator'] }
-        raise ValidationException, "Missing required key ComparisonOperator"
-      end
-
       if conditions.any? { |_, v| !v['AttributeValueList'] }
         raise ValidationException, "One or more parameter values were invalid: Invalid number of argument(s) for the ComparisonOperator"
       end

diff --git a/spec/fake_dynamo/table_spec.rb b/spec/fake_dynamo/table_spec.rb
@@ -1,6 +1,10 @@
 require 'spec_helper'
 
 module FakeDynamo
+  class ValidationTest
+    extend Validation
+  end
+
   describe Table do
 
     let(:data) do
@@ -810,7 +814,7 @@ module FakeDynamo
 
         it 'should require operator' do
           query_with_filter['QueryFilter']['score'].delete('ComparisonOperator')
-          expect { subject.query(query_with_filter) }.to raise_error(ValidationException, /missing.*ComparisonOperator/i)
+          expect { ValidationTest.validate_payload('Query', query_with_filter) }.to raise_error(ValidationException, /null.*ComparisonOperator/i)
         end
 
         it 'should handle query filter' do