refactor: reorganize rules structure

index.js

@@ -1,33 +1,23 @@
 'use strict';
 
-const commonRules = require('./common-rules');
-const jsxRules = require('./jsx-rules');
-
 module.exports = {
   overrides: [
     {
       files: ['**/*.{ts,tsx}'],
       parser: '@typescript-eslint/parser',
-      plugins: ['@typescript-eslint', 'sonarjs', 'unicorn'],
       parserOptions: {
         project: './tsconfig.json',
       },
       extends: [
-        'eslint:recommended',
-        'plugin:@typescript-eslint/recommended',
-        'plugin:@typescript-eslint/recommended-requiring-type-checking',
-        'plugin:unicorn/recommended',
-        'plugin:sonarjs/recommended',
+        'eslint-config-good-code/rules/eslint-rules',
+        'eslint-config-good-code/rules/typescript-rules',
+        'eslint-config-good-code/rules/unicorn-rules',
+        'eslint-config-good-code/rules/sonarjs-rules',
       ],
-      rules: {
-        ...commonRules,
-      },
       overrides: [
         {
           files: ['**/*.tsx'],
-          rules: {
-            ...jsxRules,
-          },
+          extends: ['./rules/jsx-rules'],
         },
       ],
     },

mit.js

@@ -0,0 +1,24 @@
+'use strict';
+
+module.exports = {
+  overrides: [
+    {
+      files: ['**/*.{ts,tsx}'],
+      parser: '@typescript-eslint/parser',
+      parserOptions: {
+        project: './tsconfig.json',
+      },
+      extends: [
+        'eslint-config-good-code/rules/eslint-rules',
+        'eslint-config-good-code/rules/typescript-rules',
+        'eslint-config-good-code/rules/unicorn-rules',
+      ],
+      overrides: [
+        {
+          files: ['**/*.tsx'],
+          extends: ['./rules/jsx-rules'],
+        },
+      ],
+    },
+  ],
+};

package.json

@@ -17,8 +17,8 @@
   },
   "homepage": "https://github.com/anantoghosh/eslint-config-good-code#readme",
   "files": [
-    "common-rules.js",
-    "jsx-rules.js",
+    "rules/**",
+    "mit.js",
     "index.js"
   ],
   "keywords": [

rules/eslint-rules.js

@@ -0,0 +1,26 @@
+module.exports = {
+  rules: {
+    /* eslint extra rules */
+    'max-lines': [
+      'error',
+      { max: 300, skipBlankLines: true, skipComments: true },
+    ],
+    'max-nested-callbacks': ['error', { max: 4 }],
+    'max-params': ['error', { max: 4 }],
+    'max-depth': ['error', 5],
+    'max-statements': ['error', 15, { ignoreTopLevelFunctions: true }],
+    'no-lonely-if': 'error',
+    'no-unneeded-ternary': 'error',
+    'no-var': 'error',
+    'eqeqeq': 'error',
+    'no-else-return': 'error',
+    'no-implicit-coercion': 'error',
+    'no-extra-bind': 'error',
+    'no-unmodified-loop-condition': 'error',
+    'radix': 'error',
+    'yoda': 'error',
+    'prefer-const': 'error',
+    'no-nested-ternary': 'error',
+  },
+  extends: ['eslint:recommended'],
+};

rules/jsx-rules.js

@@ -0,0 +1,20 @@
+module.exports = {
+  rules: {
+    'max-lines': [
+      'error',
+      { max: 350, skipBlankLines: true, skipComments: true },
+    ],
+    'max-nested-callbacks': ['error', { max: 5 }],
+    'max-depth': ['error', 6],
+
+    '@typescript-eslint/naming-convention': [
+      'error',
+      {
+        selector: 'variable',
+        format: ['camelCase', 'UPPER_CASE', 'PascalCase'],
+        leadingUnderscore: 'allow',
+        trailingUnderscore: 'allow',
+      },
+    ],
+  },
+};

rules/sonarjs-rules.js

@@ -0,0 +1,10 @@
+module.exports = {
+  rules: {
+    'sonarjs/prefer-immediate-return': 'off',
+    'sonarjs/no-redundant-boolean': 'off',
+    'sonarjs/prefer-object-literal': 'off',
+    'sonarjs/no-collapsible-if': 'off',
+  },
+  plugins: ['sonarjs'],
+  extends: ['plugin:sonarjs/recommended'],
+};