Skip to content
This repository has been archived by the owner on Dec 7, 2019. It is now read-only.

Added app icons and .DS_store to git ignore for future mac contributors #31

Merged
merged 3 commits into from Mar 5, 2019

Conversation

Wmitrut
Copy link
Contributor

@Wmitrut Wmitrut commented Mar 3, 2019

  • Added app icons on img directory in some extension formats (svg included if the generated icon will sometime be needed)

  • .DS_store to git ignore for future mac contributors because that was missing

Copy link
Owner

@anapaulagomes anapaulagomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've done a great work here @Wmitrut! If you don't mind, I'd like to ask you a few things:

  • Could you delete our temporary icon please?
  • Could you also generate an icns icon? This is used for MacOS versions.
  • Last thing (I hope 😂): could you replace this line here for this one:
    "build": "electron-packager . pardal --platform=darwin,win32,linux --icon=app/img/icon",. It will use the current directory and assign the right icons to each platform.

Many thanks!

@Wmitrut
Copy link
Contributor Author

Wmitrut commented Mar 4, 2019

Yeah!, I`ll do that!

@Wmitrut
Copy link
Contributor Author

Wmitrut commented Mar 4, 2019

Done

@anapaulagomes
Copy link
Owner

My fault: one more thing is missing and it will break stuff if we merge it: const tray = new Tray(${__dirname}/app/img/temp.png);. We just need to replace by icon.png. 🙏 @Wmitrut

I must say: the new icon is dope!

screen shot 2019-03-04 at 18 19 30

@Wmitrut
Copy link
Contributor Author

Wmitrut commented Mar 5, 2019

Easy peasy lemon squeezy - it`s done

Copy link
Owner

@anapaulagomes anapaulagomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🎉

@anapaulagomes anapaulagomes merged commit ff104e2 into anapaulagomes:master Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants