comment out LLD filters to support zabbix 2.2 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like zabbix 2.4 created additional keys for low level discovery, including creating more elaborate filters. Unfortunately, this means the new filter array cannot be imported into zabbix 2.2 without failing, even if the filters are not used. https://www.zabbix.com/documentation/2.4/manual/api/reference/discoveryrule/object vs https://www.zabbix.com/documentation/2.2/manual/api/reference/discoveryrule/object This patch simply comments out those unused filters, to allow import on zabbix 2.2.x
anapsix
added a commit
that referenced
this pull request
Apr 16, 2015
comment out LLD filters to support zabbix 2.2 Good stuff.. Since _filters_ do not appear to be used here, might as well comment it out for the sake of compatibility. Thanks @dominikborkowski
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like zabbix 2.4 created additional keys for low level discovery, including creating more elaborate filters. Unfortunately, this means the new filter array cannot be imported into zabbix 2.2 without failing, even if the filters are not used.
https://www.zabbix.com/documentation/2.4/manual/api/reference/discoveryrule/object
vs
https://www.zabbix.com/documentation/2.2/manual/api/reference/discoveryrule/object
This patch simply comments out those unused filters, to allow import on zabbix 2.2.x