Downgrade FreeBSD p5-IO-Tty 1.18->1.17. #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @macdice, Thank you for the fix! According to issue you shared, it looks like that problem won't be fixed at least until version 1.21. Do you think adding 1.19 and 1.20 to grep command is a good idea? |
|
Not sure, but a couple of people (including me just now) have pinged the maintainer, so I don't think they will be another package released that is broken like this. So I think it's OK to just look out for the known broken actually released version, and hard to predict the version that will have the fix. |
nbyavuz
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
The change looks good and I confirm that FreeBSD passes all tests with that change: https://cirrus-ci.com/task/4835937029455872.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a problem in 1.18 that breaks PostgreSQL's interactive tests. Until a fixed package rolls out, downgrade to 1.17 if 1.18 is detected.
cpan-authors/IO-Tty#38
https://www.postgresql.org/message-id/flat/757523.1705091568%40sss.pgh.pa.us