Skip to content

Commit

Permalink
lvm: add support for "all" checks
Browse files Browse the repository at this point in the history
It seems rather inconvenient to have to specify all those switches by
hand. Right now, I need to specify -gpst to get all the stats and, if
some new metric get added (e.g. prometheus-community#159 hopefully), I need to remember to
update my callers to match. This is annoying.

Let's make a -a that's going to do it all for us. Hell, i'd make it
the default, personally, if I wasn't worried about breaking people's
stuff...

This obviously conflicts with other PRs that might add another flag
like this, like prometheus-community#159. Please prioritize the latter.

Signed-off-by: Antoine Beaupré <anarcat@debian.org>
  • Loading branch information
anarcat committed Jun 6, 2023
1 parent 4098ef9 commit 0ca17e6
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion lvm-prom-collector
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,14 @@ snapshots=false
physical=false
groups=false

while getopts "htpsg" opt; do
while getopts "ahtpsg" opt; do
case $opt in
a)
thin_pools=true
snapshots=true
physical=true
groups=true
;;
p)
physical=true
;;
Expand Down

0 comments on commit 0ca17e6

Please sign in to comment.