Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

[Feature Request] Arrow Down to go back while previous command cycling #6

Closed
ndumais opened this issue Nov 18, 2022 · 6 comments
Closed

Comments

@ndumais
Copy link

ndumais commented Nov 18, 2022

Would allow to go back if you go past the command you were looking for, expected behaviour in command line.

@ndumais ndumais changed the title [Feature Request] Arrow Down to go back while command cycling [Feature Request] Arrow Down to go back while previous command cycling Nov 18, 2022
@anarkila
Copy link
Owner

Added 55c9aab. Commit is currently in the Dev branch.

@ndumais
Copy link
Author

ndumais commented Nov 26, 2022

I think it's missing the part where it handles/checks for ArrowDown keypresses?

@ndumais
Copy link
Author

ndumais commented Nov 26, 2022

image

It should be more like, "Console Search Command (Reverse) Key" or go back or something. Not sure if the issue is at the level of the feature too, but I think it might be?

Anyways, pressing arrow down, on my end, wont go back to the previous searched command.

@anarkila
Copy link
Owner

anarkila commented Dec 5, 2022

Anyways, pressing arrow down, on my end, wont go back to the previous searched command.

Currently you have to first click Up Arrow and then you can use Down Arrow to go reverse direction. I believe this how Windows CMD and Linux terminal also does it.

This same key also fills from suggested commands if they are shown. So this key serves two purposes. I understand the naming is a bit odd. I'll try to find better naming for this.

@ndumais
Copy link
Author

ndumais commented Dec 6, 2022

Ah okay, knowing that it makes more sense and mostly works. I don't mind the single key, but it seems that if you cycled previously and then autofill more than once, it will then also cycle afterwards which is a bit confusing, maybe splitting the keys or if autofill is used reset the check and only allow autofill?

@ndumais
Copy link
Author

ndumais commented Dec 6, 2022

If there's both the check and the split keys, it could also allow to use Space for autofill, which I believe is pretty common in IDEs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants