no highlight state for message prop #222
Conversation
| @@ -105,7 +105,7 @@ class Input extends React.PureComponent<InputProps, InputState> { | |||
|
|
|||
| const highlightClassName = cx(highlightStyle, { | |||
| _pebble_input_highlight_focused: isFocused, | |||
| _pebble_input_highlight_state: !!_message, | |||
| _pebble_input_highlight_state: !!errorMessage || !!successMessage, | |||
There was a problem hiding this comment.
to be frank, I don't like these classnames because they cannot be tree shaken.
No need to change anything now, I am not sure of a solution that would work with emotion 10
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
==========================================
+ Coverage 82.22% 82.24% +0.01%
==========================================
Files 75 75
Lines 1097 1098 +1
Branches 200 201 +1
==========================================
+ Hits 902 903 +1
Misses 174 174
Partials 21 21
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
==========================================
+ Coverage 82.22% 82.24% +0.01%
==========================================
Files 75 75
Lines 1097 1098 +1
Branches 200 201 +1
==========================================
+ Hits 902 903 +1
Misses 174 174
Partials 21 21
Continue to review full report at Codecov.
|
Updated:
https://app.zeplin.io/project/5c756614dd97b2bcfc2c68d9/screen/5c9b5eeb6da63805932945fd