Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure response body is always closed. #25

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Make sure response body is always closed. #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/ssllabs/analyze.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,14 +158,14 @@ func getAnalyze(target string, new bool) (result Result) {
return
}

defer response.Body.Close()

// this should happen in case of 429 or 5xx errors
if response.StatusCode != http.StatusOK {
result.Status = StatusServerError
return
}

defer response.Body.Close()

body, err := ioutil.ReadAll(response.Body)
if err != nil {
result.Status = StatusHTTPError
Expand Down