Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: early processing MakeChildren #296

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Conversation

anatawa12
Copy link
Owner

Closes #294

@anatawa12 anatawa12 marked this pull request as ready for review August 9, 2023 10:31
Localization/ja.po Outdated Show resolved Hide resolved
Localization/en.po Outdated Show resolved Hide resolved
anatawa12 and others added 2 commits August 9, 2023 21:04
Co-authored-by: Sayamame-beans <61457993+Sayamame-beans@users.noreply.github.com>
Copy link
Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docsは更新しなくても大丈夫ですか?

@anatawa12
Copy link
Owner Author

Make Children自体があんま使われる想定じゃないのもあるのでまぁDocsはいいやと思ってます。

@anatawa12 anatawa12 merged commit 48e2421 into master Aug 9, 2023
4 checks passed
@anatawa12 anatawa12 deleted the early-make-children branch August 9, 2023 12:53
@anatawa12
Copy link
Owner Author

マージしちゃったけどAnimationのremapping動かなくなる警告出す必要あるな。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Childrenがmodular avatarのPhysBoneBlockerを参照しない。
2 participants