Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Workaround BlendShape broken bug? #760

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Conversation

anatawa12
Copy link
Owner

I could not find root cause of this bug so I added workaround instead.

I know that

  • If I instantiate the generated mesh, broken BlendShapes will be fixed
  • If I duplicated the generated mesh with command + d, broken BlendShapes will be fixed
  • Even if I moved AddBlendShapeFrames before setting triangles, this will not be fixed

So, as a workaround, instantiate mesh to avoid this bug. I want to test this after dropping Unity 2019.

See #753

Closes #753 for now.

I could not find root cause of this bug so I added workaround instead.

I know that
- If I instantiate the generated mesh, broken BlendShapes will be fixed
- If I duplicated the generated mesh with command + d, broken BlendShapes will be fixed
- Even if I moved `AddBlendShapeFrame`s before setting triangles, this will not be fixed

So, as a workaround, instantiate mesh to avoid this bug.
I want to test this after dropping Unity 2019.

See #753
@anatawa12 anatawa12 mentioned this pull request Nov 29, 2023
@anatawa12 anatawa12 marked this pull request as ready for review November 29, 2023 03:26
@anatawa12 anatawa12 merged commit 1e0d8ad into master Nov 29, 2023
8 checks passed
@anatawa12 anatawa12 deleted the fix-blendshape-broken branch November 29, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RootBoneのないBlendShapeの処理がおかしい?
1 participant