Fix: Treat VRM0 BlendShapeProxy as EntryPoint #810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #809 by marking VRM0
BlendShapeProxy
as EntryPoint, just likeAnimator
.(VRM1 counterpart,
Vrm10Instance
, is already EntryPoint.)We should not access
Component.transform
here anyway, because avatar processing is at an intermediate state when FindUnusedObjects is collecting dependencies.Also I have made an assumption that AvatarOptimizer does not change Material names or remap parameter values, except when MergeToonLitMaterial is used.
(I didn't mark these comments as TODOs because I doubt "tracking material changes" would happen in near future.)