Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy way to register meaningless components #847

Merged
merged 16 commits into from
Feb 11, 2024

Conversation

anatawa12
Copy link
Owner

@anatawa12 anatawa12 commented Jan 23, 2024

Fixes #717
Fixes #822

@anatawa12 anatawa12 added the enhancement New feature or request label Jan 23, 2024
@anatawa12 anatawa12 changed the title feat(asset-description): initial commit for asset description Easy way to register meaningless components Jan 23, 2024
@anatawa12
Copy link
Owner Author

ドキュメント書かないとだけど書くの面倒...

@anatawa12 anatawa12 marked this pull request as ready for review January 24, 2024 15:13
Copy link
Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とりあえずpoファイルだけ

Localization/en.po Outdated Show resolved Hide resolved
Localization/en.po Outdated Show resolved Hide resolved
Localization/ja.po Outdated Show resolved Hide resolved
Copy link
Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelogも

残り: docsと画像

CHANGELOG.md Outdated Show resolved Hide resolved
Localization/en.po Outdated Show resolved Hide resolved
CHANGELOG-PRERELEASE.md Outdated Show resolved Hide resolved
anatawa12 and others added 2 commits January 29, 2024 00:33
Co-authored-by: Sayamame-beans <61457993+Sayamame-beans@users.noreply.github.com>
Copy link
Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とりあえずen docs

Copy link
Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ふと気付いたんですが、Avatar OptimizerとAvatarOptimzier表記が時々混ざってますね…?

Copy link
Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントの通りです(画像の文章が気になるのみ)

@anatawa12 anatawa12 merged commit e525d4c into master Feb 11, 2024
5 checks passed
@anatawa12 anatawa12 deleted the simple-api-for-non-entrypoint branch February 11, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants