Critical fix and general improvements #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MadMonkey87
commented
Jan 25, 2021
MadMonkey87
commented
- Critical fix: The timeout for reading device details was using seconds but it needs to be provided in miliseconds. This simple fix resolved all my connectivity issues
- properly mark a device as unavailable if the connection fails
- added capabilities for luminance and long term radon readings
- show connection strength in the device details
- fixed a small bug in the app manifest where the energy readings were not defined in the drivers
…connection issued
|
Fixed my connections issues straight away! Great job! |
|
Fantastic! Great job, will check into this later today and do the merge and
version update.
man. 25. jan. 2021 kl. 09:29 skrev Vegard Fladby <notifications@github.com>:
… Fixed my connections issues straight away! Great job!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABYSADWFD2N5MWHYAWUCLODS3UTWJANCNFSM4WRLQQ5A>
.
|
|
Hi! Anything preventing it from being merged, @anaxyd? Really waiting for this fix for my four (!) Wave Pluses hoping they can be usable In Homey :) |
|
Pull is now merged, and the version are uploaded to Athom for approval. You can install the test to get the changes right away: https://homey.app/a/com.airthings/test/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.