Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE at de.anbos.eclipse.easyshell.plugin.commands.DefineCommands.createContributionItems(DefineCommands.java:46) #127

Closed
sebthom opened this issue Dec 14, 2016 · 10 comments
Closed

NPE at de.anbos.eclipse.easyshell.plugin.commands.DefineCommands.createContributionItems(DefineCommands.java:46) #127

sebthom opened this issue Dec 14, 2016 · 10 comments
Assignees
@anb0s
Labels
bug help wanted question regression Version 2.1.x alpha
Milestone
v2.1

Comments

@sebthom
Copy link

sebthom commented Dec 14, 2016

After updating EasyShell to version 2.1 in Eclipse Neon.1a, context menu rendering in the project explorer is broken. I.e. some or all menu entries appear empty (without text).

The following exception is logged:

java.lang.NullPointerException
	at de.anbos.eclipse.easyshell.plugin.commands.DefineCommands.createContributionItems(DefineCommands.java:46)
	at org.eclipse.ui.internal.menus.ContributionFactoryGenerator.compute(ContributionFactoryGenerator.java:72)
	at org.eclipse.e4.ui.workbench.renderers.swt.ContributionRecord.mergeFactoryIntoModel(ContributionRecord.java:271)
	at org.eclipse.e4.ui.workbench.renderers.swt.ContributionRecord.mergeIntoModel(ContributionRecord.java:215)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.processAddition(MenuManagerRenderer.java:544)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.generateContributions(MenuManagerRenderer.java:523)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.processContributions(MenuManagerRenderer.java:491)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.processContributions(MenuManagerRenderer.java:494)
	at org.eclipse.ui.internal.PopupMenuExtender.addMenuContributions(PopupMenuExtender.java:410)
	at org.eclipse.ui.internal.PopupMenuExtender.menuAboutToShow(PopupMenuExtender.java:382)
	at org.eclipse.jface.action.MenuManager.fireAboutToShow(MenuManager.java:339)
	at org.eclipse.jface.action.MenuManager.handleAboutToShow(MenuManager.java:470)
	at org.eclipse.jface.action.MenuManager.access$1(MenuManager.java:465)
	at org.eclipse.jface.action.MenuManager$2.menuShown(MenuManager.java:497)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:256)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4410)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1103)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1084)
	at org.eclipse.swt.widgets.Control.WM_INITMENUPOPUP(Control.java:5152)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:4820)
	at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:359)
	at org.eclipse.swt.widgets.Decorations.windowProc(Decorations.java:1656)
	at org.eclipse.swt.widgets.Shell.windowProc(Shell.java:2199)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5102)
	at org.eclipse.swt.internal.win32.OS.TrackPopupMenu(Native Method)
	at org.eclipse.swt.widgets.Menu._setVisible(Menu.java:262)
	at org.eclipse.swt.widgets.Display.runPopups(Display.java:4269)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3810)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:687)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:604)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:138)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1519)
@anb0s anb0s self-assigned this Dec 14, 2016
@anb0s anb0s added this to the v2.1 milestone Dec 14, 2016
@anb0s
Copy link
Owner

anb0s commented Dec 14, 2016

Thanks. v2.1 was not released yet, so you are using one of the testing builds...

What is the build version? The last one from #122 ?
What was the previous version? I need this, because store setting where migrated from older versions...
What OS are you using?

@sebthom
Copy link
Author

sebthom commented Dec 14, 2016

Ok, I just got a popup that a new version 2.1 is available in Eclipse.

Previous version was 2.0.0.v20160927-2006 and I was asked if I want to migrate my settings and I selected "yes".

I am using it on Windows 7 64bit with a 32bit Oracle JDK8/Eclipse Neon.1a.

@anb0s
Copy link
Owner

anb0s commented Dec 15, 2016

Thanks.

i'm just curious:

  • your previous version "2.0.0.v20160927-2006" is the V2_0_0_RC3, not the final one
  • the official / final version at "http://anb0s.github.io/EasyShell" is "EasyShell 2.0.0.v20160929-1641"
    image
  • i think you are using the testing version "http://anb0s.github.io/EasyShell/testing"
    image
  • I've tested the "v2.1 beta 1", see [v2.1] testing of build 2.1.0.v20161214-2215 #129, build "2.1.0.v20161214-2215" under windows and do not see any exceptions during quick / smoke test. Please verify this version too. This version should write internal exceptions to "error log" and not affect the UI anymore. Please send me this messages.

Thank You for early testing!

@anb0s
Copy link
Owner

anb0s commented Dec 16, 2016

I want to release v2.1 in few days. Do you have news about this exception?

May be you can send me your preferences file ".metadata.plugins\org.eclipse.core.runtime.settings\de.anbos.eclipse.easyshell.plugin.prefs" for verification...

Thanks!

@sebthom
Copy link
Author

sebthom commented Dec 19, 2016

Here you go: de.anbos.eclipse.easyshell.plugin.prefs.txt

@sebthom
Copy link
Author

sebthom commented Dec 19, 2016

I installed the latest 2.1 build and the UI issue seems to be resolved. However in the logs I see this:


!ENTRY de.anbos.eclipse.easyshell.plugin 1 0 2016-12-19 12:43:57.777
!MESSAGE 
!STACK 0
de.anbos.eclipse.easyshell.plugin.exceptions.UnknownCommandID: Cannot find command data with id '899ca6b4-d5bb-4a07-8b33-1577de26eb0b'
	at de.anbos.eclipse.easyshell.plugin.preferences.MenuData.getCommandData(MenuData.java:224)
	at de.anbos.eclipse.easyshell.plugin.commands.DefineCommands.createContributionItems(DefineCommands.java:47)
	at org.eclipse.ui.internal.menus.ContributionFactoryGenerator.compute(ContributionFactoryGenerator.java:72)
	at org.eclipse.e4.ui.workbench.renderers.swt.ContributionRecord.mergeFactoryIntoModel(ContributionRecord.java:271)
	at org.eclipse.e4.ui.workbench.renderers.swt.ContributionRecord.mergeIntoModel(ContributionRecord.java:215)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.processAddition(MenuManagerRenderer.java:544)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.generateContributions(MenuManagerRenderer.java:523)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.processContributions(MenuManagerRenderer.java:491)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.processContributions(MenuManagerRenderer.java:494)
	at org.eclipse.ui.internal.PopupMenuExtender.addMenuContributions(PopupMenuExtender.java:410)
	at org.eclipse.ui.internal.PopupMenuExtender.menuAboutToShow(PopupMenuExtender.java:382)
	at org.eclipse.jface.action.MenuManager.fireAboutToShow(MenuManager.java:339)
	at org.eclipse.jface.action.MenuManager.handleAboutToShow(MenuManager.java:470)
	at org.eclipse.jface.action.MenuManager.access$1(MenuManager.java:465)
	at org.eclipse.jface.action.MenuManager$2.menuShown(MenuManager.java:497)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:256)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4410)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1103)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1084)
	at org.eclipse.swt.widgets.Control.WM_INITMENUPOPUP(Control.java:5152)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:4820)
	at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:359)
	at org.eclipse.swt.widgets.Decorations.windowProc(Decorations.java:1656)
	at org.eclipse.swt.widgets.Shell.windowProc(Shell.java:2199)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5102)
	at org.eclipse.swt.internal.win32.OS.TrackPopupMenu(Native Method)
	at org.eclipse.swt.widgets.Menu._setVisible(Menu.java:262)
	at org.eclipse.swt.widgets.Display.runPopups(Display.java:4269)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3810)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:687)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:604)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:138)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1519)

!ENTRY de.anbos.eclipse.easyshell.plugin 1 0 2016-12-19 12:43:57.782
!MESSAGE 
!STACK 0
de.anbos.eclipse.easyshell.plugin.exceptions.UnknownCommandID: Cannot find command data with id '0b799787-ba36-4f6a-bfac-c0c21a23036a'
	at de.anbos.eclipse.easyshell.plugin.preferences.MenuData.getCommandData(MenuData.java:224)
	at de.anbos.eclipse.easyshell.plugin.commands.DefineCommands.createContributionItems(DefineCommands.java:47)
	at org.eclipse.ui.internal.menus.ContributionFactoryGenerator.compute(ContributionFactoryGenerator.java:72)
	at org.eclipse.e4.ui.workbench.renderers.swt.ContributionRecord.mergeFactoryIntoModel(ContributionRecord.java:271)
	at org.eclipse.e4.ui.workbench.renderers.swt.ContributionRecord.mergeIntoModel(ContributionRecord.java:215)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.processAddition(MenuManagerRenderer.java:544)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.generateContributions(MenuManagerRenderer.java:523)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.processContributions(MenuManagerRenderer.java:491)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.processContributions(MenuManagerRenderer.java:494)
	at org.eclipse.ui.internal.PopupMenuExtender.addMenuContributions(PopupMenuExtender.java:410)
	at org.eclipse.ui.internal.PopupMenuExtender.menuAboutToShow(PopupMenuExtender.java:382)
	at org.eclipse.jface.action.MenuManager.fireAboutToShow(MenuManager.java:339)
	at org.eclipse.jface.action.MenuManager.handleAboutToShow(MenuManager.java:470)
	at org.eclipse.jface.action.MenuManager.access$1(MenuManager.java:465)
	at org.eclipse.jface.action.MenuManager$2.menuShown(MenuManager.java:497)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:256)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4410)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1103)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1084)
	at org.eclipse.swt.widgets.Control.WM_INITMENUPOPUP(Control.java:5152)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:4820)
	at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:359)
	at org.eclipse.swt.widgets.Decorations.windowProc(Decorations.java:1656)
	at org.eclipse.swt.widgets.Shell.windowProc(Shell.java:2199)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5102)
	at org.eclipse.swt.internal.win32.OS.TrackPopupMenu(Native Method)
	at org.eclipse.swt.widgets.Menu._setVisible(Menu.java:262)
	at org.eclipse.swt.widgets.Display.runPopups(Display.java:4269)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3810)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:687)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:604)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:138)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1519)

!ENTRY de.anbos.eclipse.easyshell.plugin 1 0 2016-12-19 12:43:57.789
!MESSAGE 
!STACK 0
de.anbos.eclipse.easyshell.plugin.exceptions.UnknownCommandID: Cannot find command data with id '8c71c636-1896-40f7-b7b6-f54f97737764'
	at de.anbos.eclipse.easyshell.plugin.preferences.MenuData.getCommandData(MenuData.java:224)
	at de.anbos.eclipse.easyshell.plugin.commands.DefineCommands.createContributionItems(DefineCommands.java:47)
	at org.eclipse.ui.internal.menus.ContributionFactoryGenerator.compute(ContributionFactoryGenerator.java:72)
	at org.eclipse.e4.ui.workbench.renderers.swt.ContributionRecord.mergeFactoryIntoModel(ContributionRecord.java:271)
	at org.eclipse.e4.ui.workbench.renderers.swt.ContributionRecord.mergeIntoModel(ContributionRecord.java:215)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.processAddition(MenuManagerRenderer.java:544)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.generateContributions(MenuManagerRenderer.java:523)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.processContributions(MenuManagerRenderer.java:491)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.processContributions(MenuManagerRenderer.java:494)
	at org.eclipse.ui.internal.PopupMenuExtender.addMenuContributions(PopupMenuExtender.java:410)
	at org.eclipse.ui.internal.PopupMenuExtender.menuAboutToShow(PopupMenuExtender.java:382)
	at org.eclipse.jface.action.MenuManager.fireAboutToShow(MenuManager.java:339)
	at org.eclipse.jface.action.MenuManager.handleAboutToShow(MenuManager.java:470)
	at org.eclipse.jface.action.MenuManager.access$1(MenuManager.java:465)
	at org.eclipse.jface.action.MenuManager$2.menuShown(MenuManager.java:497)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:256)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4410)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1103)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1084)
	at org.eclipse.swt.widgets.Control.WM_INITMENUPOPUP(Control.java:5152)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:4820)
	at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:359)
	at org.eclipse.swt.widgets.Decorations.windowProc(Decorations.java:1656)
	at org.eclipse.swt.widgets.Shell.windowProc(Shell.java:2199)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5102)
	at org.eclipse.swt.internal.win32.OS.TrackPopupMenu(Native Method)
	at org.eclipse.swt.widgets.Menu._setVisible(Menu.java:262)
	at org.eclipse.swt.widgets.Display.runPopups(Display.java:4269)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3810)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:687)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:604)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:138)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1519)

!ENTRY de.anbos.eclipse.easyshell.plugin 1 0 2016-12-19 12:43:57.793
!MESSAGE 
!STACK 0
de.anbos.eclipse.easyshell.plugin.exceptions.UnknownCommandID: Cannot find command data with id 'f29056d1-1502-4143-9852-2debe933f457'
	at de.anbos.eclipse.easyshell.plugin.preferences.MenuData.getCommandData(MenuData.java:224)
	at de.anbos.eclipse.easyshell.plugin.commands.DefineCommands.createContributionItems(DefineCommands.java:47)
	at org.eclipse.ui.internal.menus.ContributionFactoryGenerator.compute(ContributionFactoryGenerator.java:72)
	at org.eclipse.e4.ui.workbench.renderers.swt.ContributionRecord.mergeFactoryIntoModel(ContributionRecord.java:271)
	at org.eclipse.e4.ui.workbench.renderers.swt.ContributionRecord.mergeIntoModel(ContributionRecord.java:215)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.processAddition(MenuManagerRenderer.java:544)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.generateContributions(MenuManagerRenderer.java:523)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.processContributions(MenuManagerRenderer.java:491)
	at org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRenderer.processContributions(MenuManagerRenderer.java:494)
	at org.eclipse.ui.internal.PopupMenuExtender.addMenuContributions(PopupMenuExtender.java:410)
	at org.eclipse.ui.internal.PopupMenuExtender.menuAboutToShow(PopupMenuExtender.java:382)
	at org.eclipse.jface.action.MenuManager.fireAboutToShow(MenuManager.java:339)
	at org.eclipse.jface.action.MenuManager.handleAboutToShow(MenuManager.java:470)
	at org.eclipse.jface.action.MenuManager.access$1(MenuManager.java:465)
	at org.eclipse.jface.action.MenuManager$2.menuShown(MenuManager.java:497)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:256)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4410)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1103)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1084)
	at org.eclipse.swt.widgets.Control.WM_INITMENUPOPUP(Control.java:5152)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:4820)
	at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:359)
	at org.eclipse.swt.widgets.Decorations.windowProc(Decorations.java:1656)
	at org.eclipse.swt.widgets.Shell.windowProc(Shell.java:2199)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5102)
	at org.eclipse.swt.internal.win32.OS.TrackPopupMenu(Native Method)
	at org.eclipse.swt.widgets.Menu._setVisible(Menu.java:262)
	at org.eclipse.swt.widgets.Display.runPopups(Display.java:4269)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3810)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:687)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:604)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:138)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1519)

@anb0s
Copy link
Owner

anb0s commented Dec 19, 2016

Thanks! It's exactly what i need!

The command-IDs:
899ca6b4-d5bb-4a07-8b33-1577de26eb0b
0b799787-ba36-4f6a-bfac-c0c21a23036a
8c71c636-1896-40f7-b7b6-f54f97737764
f29056d1-1502-4143-9852-2debe933f457
belongs to wrongly migrated legacy commands "v1.4.x" and it was fixed with #102. It looks like regression: New store just removes them without clearing the menu entries...

I will investigate and fix it for final 2.1

@anb0s anb0s mentioned this issue Dec 19, 2016
Closed
36 tasks
anb0s added a commit that referenced this issue Dec 19, 2016
@anb0s
#127 extended handling of UnknownCommandID exception
97eaf6a 
Signed-off-by: Andre Bossert <anb0s@anbos.de>
anb0s added a commit that referenced this issue Dec 20, 2016
@anb0s
#127 refactoring of store handling
d74beaa 
- added store save
- added store verify and repair
@anb0s anb0s mentioned this issue Dec 20, 2016
Closed
51 tasks
@anb0s
Copy link
Owner

anb0s commented Dec 20, 2016

done for build from #135
tested with linux and defect store, windows will be tested soon...

@anb0s
Copy link
Owner

anb0s commented Dec 21, 2016

verified build #135 with your preference file under windows and it works:
image

P.S.: Hint: you have no modifications of default commands in your settings, so you can just "Restore Defaults" if you want to get rid of the duplicate entries named with "v1.4.x":
image

this entries where wrongly introduced with v2.0. But i do not want to implement logic in v2.1 to remove them by plugin automatically, because may be some users have really upgraded from 1.4.x and the loose their settings then... may be i will add a dialog for this later.

Thanks!

@anb0s
Copy link
Owner

anb0s commented Dec 22, 2016 •
edited

Looks good, for me --> CLOSE

Please reopen if still an issue, Thanks!

@anb0s anb0s closed this as completed Dec 22, 2016
@anb0s anb0s mentioned this issue Apr 21, 2017
Closed
54 tasks
@anb0s anb0s mentioned this issue May 8, 2017
Closed
55 tasks
anb0s added a commit that referenced this issue May 9, 2017
@anb0s
EasyShell v2.1.0
09a7d2e 
- [x] #150 [v2.1] testing of build 2.1.0.v20170508-1844
  - [x] #101 add Run command for Mac OS X
  - [x] #148 add Q-Dir (Quad Explorer) preset
  - [x] #149 "Unhandled event loop exception" with 36 menu items and
quick menu
- [x] #147 [v2.1] testing of build 2.1.0.v20170421-1258
  - [x] #28 Show EasyShell entry on maven dependencies
  - [x] #84 add support for multipage editor
  - [x] #136 [v2.0] possibility to change menu icons
  - [x] #137 add DoubleCommander support
  - [x] #138 add GNOME Commander support
  - [x] #139 add Sunflower file browser support
  - [x] #140 add Midnight Commander support
  - [x] #141 cannot run file in terminal --- Neon3 and Ubuntu 16.04
  - [x] #142 exception in 'Variables Test'
  - [x] #143 adapt sakura terminal emulator command
  - [x] #144 rework all 'Run' commands
  - [x] #145 add Msys2 / MinGW32 / MinGW64 bash preset
  - [x] #146 add EasyShell branding information
- [x] #135 [v2.1] testing of build 2.1.0.v20161220-2025
  - [x] #127 NPE at
de.anbos.eclipse.easyshell.plugin.commands.DefineCommands.createContributionItems(DefineCommands.java:46)
  - [x] #134 [v2.1] [menu dialog] command and name are editable but
should be read-only
- [x] #133 [v2.1] testing of build 2.1.0.v20161218-1511
  - [x] #130 [v2.1] menu dialog looks weird
  - [x] #131 [v2.1] [command dialog] "split command" has no effect for
"clipboard" type
  - [x] #132 [v2.1] fix quotes and "split command" in windows presets
- [x] #129 [v2.1] testing of build 2.1.0.v20161214-2215
  - [x] #123 [v2.1] guake preset does not work with 2.1.0.v20161210-2045
  - [x] #124 [v2.0] run presets with single quotes are not working
  - [x] #125 add Enlightenment (Terminology emulator)
  - [x] #126 [v2.0] add search or filter for faster selection of
commands in menu dialog
  - [x] #128 [v2.1] add exceptions for internal errors
- [x] #122 [v2.1] testing of build 2.1.0.v20161210-2045
  - [x] #105 [v2.1] add option for showing tooltips
  - [x] #115 add option for debug output in console
  - [x] #118 [build 2.1.0.v20161203-1029] crash if using new "Split
spaces only" option
  - [x] #119 [v2.0] add variables for parent container
  - [x] #120 [build 2.1.0.v20161203-1029] presets modifications are
removed after each second edit
  - [x] #121 [v2.0] add TotalCommander presets for left and right
windows
- [x] #117 testing of build 2.1.0.v20161203-1029
  - [x] #112 add linux guake support
  - [x] #113 add linux krusader support
  - [x] #116 [v2.0] plugin presets are stored together with user
modifications --> migration of presets not possible
- [x] #111 [v2.1] testing of build 2.1.0.v20161103-2010
  - [x] #18 check compatibility to other terminal emulators
  - [x] #102 Menu contains each item twice on Mac OS (by default)
  - [x] #106 [v2.0] keyboard shortcuts are not working in popup menu
under Linux
  - [x] #107 [v2.0] add support for external files
  - [x] #108 add mate-terminal support
  - [x] #109 add mate Caja (MATE) file browser support
  - [x] #110 LXDE: add lxterminal support
- [x] #104 [v2.1] testing of build 2.1.0.v20161102-1515
  - [x] #76 [v2.0] Steps to build the plugin using the source code
  - [x] #98 add support for PowerCmd
  - [x] #99 add support iTerm2 in Mac
  - [x] #100 add open with Default application for Mac OS X
  - [x] #103 After copied file path, a tool-tip "Copied to clipboard"
always exists.

Signed-off-by: Andre Bossert <anb0s@anbos.de>
anb0s added a commit that referenced this issue May 9, 2017
@anb0s
EasyShell v2.1.0
5f962b1 
- [x] #150 [v2.1] testing of build 2.1.0.v20170508-1844
  - [x] #101 add Run command for Mac OS X
  - [x] #148 add Q-Dir (Quad Explorer) preset
  - [x] #149 "Unhandled event loop exception" with 36 menu items and
quick menu
- [x] #147 [v2.1] testing of build 2.1.0.v20170421-1258
  - [x] #28 Show EasyShell entry on maven dependencies
  - [x] #84 add support for multipage editor
  - [x] #136 [v2.0] possibility to change menu icons
  - [x] #137 add DoubleCommander support
  - [x] #138 add GNOME Commander support
  - [x] #139 add Sunflower file browser support
  - [x] #140 add Midnight Commander support
  - [x] #141 cannot run file in terminal --- Neon3 and Ubuntu 16.04
  - [x] #142 exception in 'Variables Test'
  - [x] #143 adapt sakura terminal emulator command
  - [x] #144 rework all 'Run' commands
  - [x] #145 add Msys2 / MinGW32 / MinGW64 bash preset
  - [x] #146 add EasyShell branding information
- [x] #135 [v2.1] testing of build 2.1.0.v20161220-2025
  - [x] #127 NPE at
de.anbos.eclipse.easyshell.plugin.commands.DefineCommands.createContributionItems(DefineCommands.java:46)
  - [x] #134 [v2.1] [menu dialog] command and name are editable but
should be read-only
- [x] #133 [v2.1] testing of build 2.1.0.v20161218-1511
  - [x] #130 [v2.1] menu dialog looks weird
  - [x] #131 [v2.1] [command dialog] "split command" has no effect for
"clipboard" type
  - [x] #132 [v2.1] fix quotes and "split command" in windows presets
- [x] #129 [v2.1] testing of build 2.1.0.v20161214-2215
  - [x] #123 [v2.1] guake preset does not work with 2.1.0.v20161210-2045
  - [x] #124 [v2.0] run presets with single quotes are not working
  - [x] #125 add Enlightenment (Terminology emulator)
  - [x] #126 [v2.0] add search or filter for faster selection of
commands in menu dialog
  - [x] #128 [v2.1] add exceptions for internal errors
- [x] #122 [v2.1] testing of build 2.1.0.v20161210-2045
  - [x] #105 [v2.1] add option for showing tooltips
  - [x] #115 add option for debug output in console
  - [x] #118 [build 2.1.0.v20161203-1029] crash if using new "Split
spaces only" option
  - [x] #119 [v2.0] add variables for parent container
  - [x] #120 [build 2.1.0.v20161203-1029] presets modifications are
removed after each second edit
  - [x] #121 [v2.0] add TotalCommander presets for left and right
windows
- [x] #117 testing of build 2.1.0.v20161203-1029
  - [x] #112 add linux guake support
  - [x] #113 add linux krusader support
  - [x] #116 [v2.0] plugin presets are stored together with user
modifications --> migration of presets not possible
- [x] #111 [v2.1] testing of build 2.1.0.v20161103-2010
  - [x] #18 check compatibility to other terminal emulators
  - [x] #102 Menu contains each item twice on Mac OS (by default)
  - [x] #106 [v2.0] keyboard shortcuts are not working in popup menu
under Linux
  - [x] #107 [v2.0] add support for external files
  - [x] #108 add mate-terminal support
  - [x] #109 add mate Caja (MATE) file browser support
  - [x] #110 LXDE: add lxterminal support
- [x] #104 [v2.1] testing of build 2.1.0.v20161102-1515
  - [x] #76 [v2.0] Steps to build the plugin using the source code
  - [x] #98 add support for PowerCmd
  - [x] #99 add support iTerm2 in Mac
  - [x] #100 add open with Default application for Mac OS X
  - [x] #103 After copied file path, a tool-tip "Copied to clipboard"
always exists.

Signed-off-by: Andre Bossert <anb0s@anbos.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anb0s anb0s

Labels
bug help wanted question regression Version 2.1.x alpha
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
2 participants
@anb0s @sebthom