Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context menu in "Git Repositories" window shows only "show in" entry with EasyShell installed #195

Closed
simon-hyggeonkel opened this issue May 21, 2021 · 11 comments
Assignees
Milestone

Comments

@simon-hyggeonkel
Copy link

Expected Behavior

when right clicking a repository, or a specific branch, I expect to see a long list of options such as pull and checkout.

Actual Behavior

What I am presented with is only the "Show In" menu entry.

Steps to Reproduce the Problem

Install EasyShell plugin V. 2.2.0
Switch to Perspective "Git"
Right click a repository in the "Git Repositories" window.

Your Environment

  • Plugin version: 2.2.0
  • Eclipse Version: Version: 2021-03 (4.19.0) Build id: 20210312-0638
  • Java Version: 15.0.1 64 bit
  • Operating System Version: Windows 10 Pro v 20H2
@simon-hyggeonkel
Copy link
Author

log.txt

Here is my log.

@anb0s
Copy link
Owner

anb0s commented May 30, 2021

Thanks, I will try to reproduce. Which eclipse distribution are you using?

P.S.: I will be available after 07.06.21 so it will took some time...

@anb0s anb0s self-assigned this May 30, 2021
@anb0s anb0s added this to the TBD milestone May 30, 2021
@tomaswolf
Copy link

Just for the record: this was originally reported in the Egit forum, including a screenshot.

@simon-hyggeonkel
Copy link
Author

Yes, that was me posting the problem in the wrong place. :)

@anb0s
Copy link
Owner

anb0s commented Jun 7, 2021

I've investigated but cannot reproduce with standard Eclipse distributions without CDT (Java, PDE etc. only). Again the question from above:

Which eclipse distribution are you using?

It looks like the CDT bundle is found, but the class IncludeReferenceProxy cannot be loaded...

@tomaswolf
Copy link

@anb0s : according to the log he posted:

Framework arguments:  -product org.eclipse.epp.package.php.product

Eclipse PHP includes org.eclipse.cdt.core, but only that. It does not include UI bundles from CDT.

ResourceUtilsCDT checks for two classes from CDT UI, but is guarded only by a check for CDT core.

@anb0s
Copy link
Owner

anb0s commented Jun 7, 2021

@tomaswolf : ah yes, thank you! I will extend the guard for ui bundle and add catch for all exceptions as this should not throw and not corrupt the menu propagation

anb0s added a commit that referenced this issue Jun 7, 2021
with EasyShell installed #195

Signed-off-by: Andre Bossert <anb0s@anbos.de>
anb0s added a commit that referenced this issue Jun 7, 2021
with EasyShell installed #195

Signed-off-by: Andre Bossert <anb0s@anbos.de>
@anb0s
Copy link
Owner

anb0s commented Jun 7, 2021

Please try the testing version: 2.2.1.v20210607-1525
It is available at the testing update site now: http://anb0s.github.io/EasyShell/testing

@tomaswolf
Copy link

tomaswolf commented Jun 7, 2021

That solves the problem.

  1. Downloaded Eclipse PHP (2021-03).
  2. Opened the Git Repositories view, imported an existing repository, verified all menu entries present.
  3. Installed EasyShell from Marketplace: menu entries in Git Repositories view are gone.
  4. Installed EasyShell 2.2.1 from the above testing update site: menus are back.

@anb0s
Copy link
Owner

anb0s commented Jun 8, 2021

@tomaswolf Thanks! I have tested similar installation and it works for me too.
@simon-hyggeonkel new version will be released soon please use testing until

anb0s added a commit that referenced this issue Jul 16, 2021
fixes #195

#195

Signed-off-by: Andre Bossert <anb0s@anbos.de>
@anb0s anb0s mentioned this issue Jul 16, 2021
anb0s added a commit that referenced this issue Jul 16, 2021
with EasyShell installed #195

Signed-off-by: Andre Bossert <anb0s@anbos.de>
@anb0s anb0s closed this as completed in d062c71 Jul 16, 2021
anb0s added a commit that referenced this issue Jul 16, 2021
fixes #195

#195

Signed-off-by: Andre Bossert <anb0s@anbos.de>
@anb0s
Copy link
Owner

anb0s commented Jul 16, 2021

Please use released version: EasyShell v2.2: 2.2.1.v20210716-0745

@anb0s anb0s modified the milestones: TBD, v2.2.1 Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants