Allow API Version to be explicitly specified in env var or cmd options #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Goodman <pete@petegoo.com>
PeteGoo
force-pushed
the
AllowSkipApiVersionCheck
branch
from
fffdfc1
to
541b2c3
Compare
Signed-off-by: Peter Goodman <pete@petegoo.com>
|
Thanks @PeteGoo ! I'll review and update this ticket tomorrow, but at first glance this seems like a reasonable approach and PR. |
|
@PeteGoo , this looks good thanks! I'll go ahead and merge it. There will likely be changes in this area of the client for upcoming releases as well due to some upcoming changes in the service side to present version information more efficiently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an Anchore engine where access to the swagger.json endpoint is restricted and hence the detection of api versions fails. This results in a call to get_image that presumes an older api and sends a payload on the get request resulting in a 403 from CloudFront in this case.
To remedy this, I have added an explicit option for specifying the api version either via environment variable or cli option. When this has been specified, the version check will be skipped.
Hopefully other people will find this useful.