Enforce Import Ordering (Isort) #1143
Conversation
Signed-off-by: Vijay Pillai <vijay.pillai@anchore.com>
Signed-off-by: Vijay Pillai <vijay.pillai@anchore.com>
Signed-off-by: Vijay Pillai <vijay.pillai@anchore.com>
Signed-off-by: Vijay Pillai <vijay.pillai@anchore.com>
ad9b7c6
to
ece4430
Compare
Signed-off-by: Vijay Pillai <vijay.pillai@anchore.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, a great clean-up. Just have to run some test tomorrow and I think it should be good to go.
The following test looks good.
|
@Vijay-P Is there a way (I am assuming there is) to add an isort plugin to pycharm (and vscode) to run automatically on every save? If so, can you add it to the README? |
The engineering repo might be a better place for it, but it should be documented somewhere. |
yes, absolutely |
|
What this PR does / why we need it:
This PR utilizes isort to enforce import ordering across all modules that follows python best practices.
make lint
shell script to check import orderingWhich issue this PR fixes (optional, in
fixes #<issue number>)(, fixes #<issue_number, ...)
format, will close the issue when PR is merged: fixes #:Special notes: