Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Windows #17

Open
willmurphyscode opened this issue Mar 12, 2024 · 4 comments · May be fixed by #22
Open

Support Windows #17

willmurphyscode opened this issue Mar 12, 2024 · 4 comments · May be fixed by #22
Assignees
@willmurphyscode

Comments

@willmurphyscode
Copy link
Contributor

We'd like to release binny for Windows so that projects using binny to manager their binary dependencies are easier to work on on Windows.

Right now, there are a few obstacles to this:

  1. Binny doesn't compile on Windows due to directly using the syscall.SIGWINCH constant, which doesn't exist on Windows. To fix that, we should pull all the fancy terminal UI stuff into separate files that aren't built on Windows.
  2. Binny has no Windows CI - we should get at least unit tests running on Windows
  3. Binny has no Windows release artifacts - this should be a simple goreleaser config change
  4. Binny has no Windows-compatible install script. Maybe adding install.ps1 to the repo, or maybe publishing to chocalatey is the right path here.
@willmurphyscode
Copy link
Contributor Author

This would make adding tests to anchore/syft#2654 a lot easier.

@willmurphyscode
Copy link
Contributor Author

https://gist.github.com/f3l3gy/0e89dde158dde024959e36e915abf6bd might be how we'd do an install script.

@willmurphyscode willmurphyscode mentioned this issue Mar 12, 2024
Merged
@willmurphyscode willmurphyscode mentioned this issue Apr 8, 2024
Merged
@willmurphyscode
Copy link
Contributor Author

Adding CLI tests as a step towards this: #21

@willmurphyscode willmurphyscode linked a pull request May 9, 2024 that will close this issue
Draft
@willmurphyscode
Copy link
Contributor Author

Current issue facing this is that running go install to a temp directory and then trying to rename the resulting .exe to the .tool directory fails with permission denied errors on Windows, and I haven't figured out why yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willmurphyscode willmurphyscode

Labels
None yet
Projects
OSS
Status: Stalled
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: release on windows anchore/binny
1 participant
@willmurphyscode