make basic version of run on Windows
#18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pty and syscall.SIGWINCH will not work on Windows. Make the command a basic pass-through so it will compile on Windows. Signed-off-by: Will Murphy <will.murphy@anchore.com>
This way, even if it takes a while for us to start publishing windows release artifacts, PRs that prevent the tool from compiling at all on windows will be blocked. Signed-off-by: Will Murphy <will.murphy@anchore.com>
willmurphyscode
changed the title
run on Windows
wagoodman
reviewed
Mar 14, 2024
wagoodman
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pty and syscall.SIGWINCH will not work on Windows. Make the command a basic pass-through so it will compile on Windows.
Tries to address part 1 on #17.