Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Dockerfile & compose file #24

Merged
merged 4 commits into from
Mar 6, 2023
Merged

feat: add Dockerfile & compose file #24

merged 4 commits into from
Mar 6, 2023

Conversation

HN23
Copy link
Member

@HN23 HN23 commented Jan 18, 2023

Adding the docker-compose.yml with a single service as an example as well as just the Dockerfile. This PR does not include the release make task or any goreleaser stuff yet.

Signed-off-by: Hung Nguyen <hung.tran.nguyen.585@gmail.com>
…cker-compose example

Signed-off-by: Hung Nguyen <hung.tran.nguyen.585@gmail.com>
FROM scratch
COPY --from=build /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt

WORKDIR /tmp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why tmp?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was modeling it after Syft:
https://github.com/anchore/syft/blob/main/Dockerfile#L8

If you have a preference on where it can go, I can update it.

Copy link
Contributor

@robcresswell robcresswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hung! Left some comments

Signed-off-by: Hung Nguyen <hung.tran.nguyen.585@gmail.com>
Signed-off-by: Hung Nguyen <hung.tran.nguyen.585@gmail.com>
Copy link
Member

@bradleyjones bradleyjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge and iterate from there

@bradleyjones bradleyjones changed the title Dockerfile feat: add Dockerfile & compose file Mar 6, 2023
@bradleyjones bradleyjones merged commit 52a9218 into main Mar 6, 2023
@bradleyjones bradleyjones deleted the dockerfile branch March 6, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants