-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Dockerfile & compose file #24
Conversation
Signed-off-by: Hung Nguyen <hung.tran.nguyen.585@gmail.com>
…cker-compose example Signed-off-by: Hung Nguyen <hung.tran.nguyen.585@gmail.com>
FROM scratch | ||
COPY --from=build /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/ca-certificates.crt | ||
|
||
WORKDIR /tmp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why tmp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was modeling it after Syft:
https://github.com/anchore/syft/blob/main/Dockerfile#L8
If you have a preference on where it can go, I can update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hung! Left some comments
Signed-off-by: Hung Nguyen <hung.tran.nguyen.585@gmail.com>
Signed-off-by: Hung Nguyen <hung.tran.nguyen.585@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's merge and iterate from there
Adding the docker-compose.yml with a single service as an example as well as just the Dockerfile. This PR does not include the release make task or any goreleaser stuff yet.