Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add username, groupname, digest algorithm, and fileflag support for file listing #2

Merged
merged 4 commits into from Apr 12, 2021
Merged

Add username, groupname, digest algorithm, and fileflag support for file listing #2

merged 4 commits into from Apr 12, 2021

Conversation

wagoodman
Copy link

@wagoodman wagoodman commented Apr 12, 2021 •
edited

Adds the following fields for each file listing:

  • username
  • groupname
  • file flag parser + stringer
  • file digest algorithm support

Partially addresses anchore/syft#371 , specifically anchore/syft#371 (comment)

@wagoodman
add username, groupname, and fileflag support
8decccf 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman force-pushed the add-user-group-file-flag-support branch from 911eeee to 8decccf Compare April 12, 2021 12:05
@wagoodman wagoodman requested a review from a team April 12, 2021 12:05
@wagoodman wagoodman marked this pull request as draft April 12, 2021 12:06
@wagoodman
rename local entry variable to not override type
5e5bacd 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman
add file digest algorithm support
6c59ba2 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman
update test cases with file digest algorithms
22b531d 
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman changed the title Add username, groupname, and fileflag support for file listing Add username, groupname, digest algorithm, and fileflag support for file listing Apr 12, 2021
@wagoodman wagoodman self-assigned this Apr 12, 2021
@wagoodman wagoodman added the enhancement New feature or request label Apr 12, 2021
@wagoodman wagoodman marked this pull request as ready for review April 12, 2021 12:40
luhring
luhring approved these changes Apr 12, 2021
View reviewed changes
Copy link

@luhring luhring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. When you get a chance, it would be nice to create some sort of follow-up artifact for the upstream repo — even if just an issue pointing to this PR.

@wagoodman
Copy link
Author

yup @luhring the goal is to submit PRs upstream 👍

@wagoodman wagoodman merged commit 52818be into master Apr 12, 2021
@wagoodman wagoodman deleted the add-user-group-file-flag-support branch April 12, 2021 20:30
@wagoodman wagoodman mentioned this pull request Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhring luhring luhring approved these changes

Assignees

@wagoodman wagoodman

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@wagoodman @luhring