Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grype doesn't exit cleanly on error #1492

Closed
luhring opened this issue Sep 15, 2023 · 0 comments · Fixed by #1505
Closed

Grype doesn't exit cleanly on error #1492

luhring opened this issue Sep 15, 2023 · 0 comments · Fixed by #1505
Assignees
@kzantow
Labels
bug Something isn't working

Comments

@luhring
Copy link
Contributor

luhring commented Sep 15, 2023

What happened:

When I run Grype and give an image reference for an image that doesn't exist, Grype appears not to exit cleanly. The symptom I noticed was that it doesn't restore the cursor to the terminal. I'm not sure what else wasn't handled correctly.

What you expected to happen:

No lasting changes to user's terminal after running Grype

How to reproduce it (as minimally and precisely as possible):

grype ghcr.io/luhring/does-not-exist

Anything else we need to know?:

Environment:

  • Output of grype version:
Application:     grype
Version:         0.68.0
BuildDate:       2023-09-14T21:27:00Z
GitCommit:       a87e198e58a446e887e00399021852bb0e1ea2e5
GitDescription:  v0.68.0
Platform:        darwin/arm64
GoVersion:       go1.21.1
Compiler:        gc
SyftVersion:     v0.90.0
  • OS (e.g: cat /etc/os-release or similar):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kzantow kzantow

Labels
bug Something isn't working
Projects
OSS
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: terminal clobbering when commands return errors kzantow-anchore/grype
2 participants
@kzantow @luhring