Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update yardstick to diagnose intermittent quality gate test failures #1054

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

kzantow
Copy link
Contributor

@kzantow kzantow commented Jan 9, 2023

This PR updates the quality gate yardstick to print more errors if unable to get the latest grype version from the github api.

Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow kzantow changed the title chore: update yardstick to diagnose intermittent failures chore: update yardstick to diagnose intermittent test quality gate failures Jan 9, 2023
@kzantow kzantow changed the title chore: update yardstick to diagnose intermittent test quality gate failures chore: update yardstick to diagnose intermittent quality gate test failures Jan 9, 2023
@kzantow kzantow merged commit b01678d into anchore:main Jan 9, 2023
@kzantow kzantow deleted the chore/update-yardstick branch January 9, 2023 22:44
@wagoodman
Copy link
Contributor

I think for this to work you'd also need to change this: https://github.com/anchore/grype/blob/main/.github/workflows/validations.yaml#L156-L157

to include the token

- name: Run quality tests
  run: make quality
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

(^ I think...)

@kzantow
Copy link
Contributor Author

kzantow commented Jan 10, 2023

@wagoodman yes, I've intentionally omitted it for now to try to observe the actual error but that's what is needed for the next bit 👍

spiffcs added a commit to willyw0nka/grype that referenced this pull request Jan 24, 2023
* main: (56 commits)
  fix: always include severity in cyclonedx output (anchore#1067)
  Update Syft to v0.68.0 (anchore#1064)
  Add protobuf FPs to default ignore list (anchore#1062)
  chore: update Syft to v0.66.2 (anchore#1060)
  Update grype bootstrap tools to latest versions. (anchore#1055)
  feat: allow grype db diff to specify local db directories (anchore#1058)
  chore: claim artifacthub package ownership from developer-guy (anchore#661)
  chore: add github token to quality tests (anchore#1056)
  chore: update yardstick to diagnose intermittent failures (anchore#1054)
  Update grype bootstrap tools to latest versions. (anchore#1048)
  fix: sort vulnerability results (anchore#1052)
  Adding internal/file/hasher test cases (anchore#1049)
  fix: orient by cve merging (anchore#1046)
  Update Syft to v0.64.0 (anchore#1047)
  fix: update removing results based on ownership-by-file-overlap (anchore#1045)
  feat: swap custom cyclone-dx model for cyclone-dx library (anchore#1038)
  chore: add GitLab Community Edition image to quality gate (anchore#1035)
  Update Syft to v0.63.0 (anchore#1037)
  fix: Exclude binary packages that have overlap by file ownership relationship (anchore#1024)
  docs: update quality gate docs (anchore#1032)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants