fix: by-cpe pivot by vuln metadata rather than vulnerability record #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weston Steimel <weston.steimel@anchore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
--by-cvelogic to only reorient the vulnerability metadata around NVD data rather than attempting to get the corresponding vulnerability table record. This will address performance concerns since their was no index onid, namespaceon the vulnerabilities table, but there is on thevulnerability_metadatatable. This also preserves the fixed in information from the actual match rather than losing it since the NVD data has no fix info. It also correctly returns the CVE identifier in cases where there is more than one vulnerability record for a givenid, namespacesince that is the primary key on thevulnerability_metadatatable.Fixes #1185