feat: package qualifier for platform CPE #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonsteimel
force-pushed
the
platform-cpe-qualifier
branch
2 times, most recently
from
5bc3d14
to
a206485
Compare
This allows filtering vulnerability matches that are only applicable when running on specific platforms. It currently supports filtering matches that are only applicable for windows, debian, and ubuntu when the underlying distro is known and does not match. Additionally, wordpress platform matches are always filtered since wordpress plugins are not currently discoverable by syft and can be a significant source of false-positive matches. These are already filtered when the target software component of the CPE is used rather than a running on platform CPE configuration. Signed-off-by: Weston Steimel <weston.steimel@anchore.com>
westonsteimel
force-pushed
the
platform-cpe-qualifier
branch
from
a206485
to
bb1f3ef
Compare
wagoodman
reviewed
May 17, 2023
| @@ -6,16 +6,17 @@ import ( | |||
| "github.com/stretchr/testify/assert" | |||
|
|
|||
| "github.com/anchore/grype/grype/db/internal/sqlite" | |||
| v4 "github.com/anchore/grype/grype/db/v5" | |||
There was a problem hiding this comment.
ha! at least the import was accurate even if the alias was a lie -- good find.
wagoodman
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows filtering vulnerability matches that are only applicable when running on specific platforms. It currently supports filtering matches that are only applicable for windows, debian, and ubuntu when the underlying distro is known and does not match.
Additionally, wordpress platform matches are always filtered since wordpress plugins are not currently discoverable by syft and can be a significant source of false-positive matches. These are already filtered when the target software component of the CPE is used rather than a running on platform CPE configuration.