fix: improve sarif descriptive text and fingerprint #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Zantow <kzantow@gmail.com>
kzantow
changed the title
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Signed-off-by: Keith Zantow <kzantow@gmail.com>
spiffcs
approved these changes
Feb 20, 2024
Signed-off-by: Keith Zantow <kzantow@gmail.com>
|
@kzantow I saw you added another commit for checks against the image name to make sure it's valid for githubs API. Are there are changes going into this PR? The new commit with tests LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the descriptive text when outputting SARIF to display more information to the user including the image/ and tag or sha that was specified. An example of what this looks like in GitHub can be seen here.
Fixes #1715