Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warnings when matching go packages with devel version #1752

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

wagoodman
Copy link
Contributor

Today when you are matching against a golang package with a devel version, you see this warning:

[0000]  WARN could not match by package language (package=Pkg(type=go-module, name=./staging/src/k8s.io/api, version=(devel), upstreams=0)): matcher failed to parse version pkg="./staging/src/k8s.io/api" ver="(devel)": Malformed version: (devel)

However, this case is quite common, and there is nothing the user can do about this so we should not be showing this warning.

This PR makes the following changes:

  • an explicit error case that other version constructors can use in the future
  • changes this to a trace log

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
@wagoodman wagoodman requested a review from a team March 15, 2024 13:22
@wagoodman wagoodman self-assigned this Mar 15, 2024
@wagoodman wagoodman enabled auto-merge (squash) March 15, 2024 13:22
@wagoodman wagoodman added the bug Something isn't working label Mar 15, 2024
@wagoodman wagoodman merged commit dbc8f15 into main Mar 18, 2024
10 checks passed
@wagoodman wagoodman deleted the remove-golang-devel-warn branch March 18, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants