Add syft version to version command output #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Angelo Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Angelo Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Angelo Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Angelo Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Angelo Phillips <christopher.phillips@anchore.com>
luhring
approved these changes
Sep 16, 2021
| @@ -21,6 +21,7 @@ BOOTSTRAP_CACHE="c7afb99ad" | |||
| DISTDIR=./dist | |||
| SNAPSHOTDIR=./snapshot | |||
| GITTREESTATE=$(if $(shell git status --porcelain),dirty,clean) | |||
| SYFTVERSION=$(shell go list -m all | grep github.com/anchore/syft | awk '{print $$2}') | |||
There was a problem hiding this comment.
I don't know if this is any safer than what you've already done, but there's a "machine readable" flow using JSON, too, like this:
go list -m -json all | jq --raw-output 'select(.Path == "github.com/anchore/syft").Version'
There was a problem hiding this comment.
Sorry I just saw this comment. Happy to make the change if the taskrunners have jq installed. I used awk because I was more certain that would be available in the workflow by default than something like jq.
wagoodman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Test run
Locally you should see syft version populated in the build:
When you run:
./snapshot/grype-macos_darwin_amd64/grype versionYou should see syft version populated in the output:
