fix: allow users to properly use the file input over the default path value #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value Signed-off-by: Jose R. Gonzalez <komish@flutes.dev>
kzantow
approved these changes
May 30, 2024
|
Thanks @komish! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #389
This PR reorders conditional logic that appends image/dir/file information to the syft command such that the
fileinput to the action is parsed before thepathinput.The
pathinput has a default value (see: https://github.com/anchore/sbom-action/blob/main/action.yml#L11), and the conditional logic (modified in this PR) would see the path value is set to.(even if the user didn't provide a value) and add it to the run command. This is short-circuiting the if/else, so nothing else (in the same block) gets included in the run command.