Set the default platform for select sources based on host arch #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
wagoodman
force-pushed
the
loosen-platform-requirements
branch
from
543bdf2
to
bea3bc0
Compare
…tform Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
kzantow
approved these changes
Mar 23, 2023
| switch source { | ||
| case image.DockerTarballSource, image.OciDirectorySource, image.OciTarballSource, image.SingularitySource: | ||
| if cfg.Platform != nil { | ||
| return fmt.Errorf("specified platform=%q however image source=%q does not support selecting platform", cfg.Platform.String(), source.String()) |
There was a problem hiding this comment.
Does this need to be an error? could it just safely be ignored here?
There was a problem hiding this comment.
given that the user explicitly asked for an image with the given platform, we don't want to analyze a different image than what was intended. Logging an error would allow for the analysis to continue, and say in syft an SBOM to be produced, but the SBOM config would show a platform that differs than that of what was really analyzed (which seems wrong)
| provider = sif.NewProviderFromPath(imgStr, tempDirGenerator) | ||
| default: | ||
| return nil, fmt.Errorf("unable to determine image source") | ||
| } | ||
| return provider, nil | ||
| } | ||
|
|
||
| func setPlatform(source image.Source, cfg *config, defaultArch string) error { |
There was a problem hiding this comment.
nit: setDefaultPlatform or similar, since it does nothing if platform is set?
There was a problem hiding this comment.
that's probably the right name 👍
There was a problem hiding this comment.
Well, on second thought, this is also verifying that a non-default, non-nil platform is allowed to be set by the user... which goes beyond setting the default. There is probably a better name for this but setPlatform and setDefaultPlatform both don't quite fit the bill... but setPlatform is slightly less incorrect, so I'll leave it for now.
gnmahanth
pushed a commit
to deepfence/stereoscope
that referenced
this pull request
Jun 15, 2023
…re#152) * set the default platform for select sources based on host arch Signed-off-by: Alex Goodman <alex.goodman@anchore.com> * decompose into smaller function and add tests for setting default platform Signed-off-by: Alex Goodman <alex.goodman@anchore.com> --------- Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets a default platform to image providers that support platform options only if there is no overriding platform specified by the caller.
This should help alleviate the problems described in anchore/syft#1391 .
Fixes #149