-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link Detection Stack Depth FailSafe #159
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Benchmark Test ResultsBenchmark results from the latest changes vs base branch
|
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
wagoodman
approved these changes
Feb 22, 2023
gnmahanth
pushed a commit
to deepfence/stereoscope
that referenced
this pull request
Jun 15, 2023
* test: add failing test for cycle case Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com> * test: test updates sym links Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com> * change the filetree recursive pathset to represent open calls Signed-off-by: Alex Goodman <alex.goodman@anchore.com> * add another cycle test Signed-off-by: Alex Goodman <alex.goodman@anchore.com> * change filetree attempting path set to counters Signed-off-by: Alex Goodman <alex.goodman@anchore.com> * remove comment Signed-off-by: Alex Goodman <alex.goodman@anchore.com> * fix linting Signed-off-by: Alex Goodman <alex.goodman@anchore.com> * feat: decrement stack depth Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com> * test: remove old wip test name Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com> * chore: style updates Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com> * feat: move maxLinkDepth decrement to inside ancestor loop Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com> * feat: move maxLinkDepth decrement into resolveNodeLinks loop Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com> * feat: move detection to top and write minimal test case Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com> * test: update linkResolution test to use internal value Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com> --------- Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com> Signed-off-by: Alex Goodman <alex.goodman@anchore.com> Co-authored-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary Follow up to #158
We want to enable a max stack depth so that if the given condition fails to catch any edge cases in #158 stereoscope can still exit safely and report an error.
Tradeoffs
This does leave us open to large stack depth resolutions that are >
MaxLinkDepth
, but given those cases we can always bump the number to allow for images with large calls toresolveAncestorLinks