Preserve time and expose link strategy #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Wobito <adrian.wobito@gmail.com>
Signed-off-by: Adrian Wobito <adrian.wobito@gmail.com>
wobito
force-pushed
the
preserve_time_and_expose_link_strat
branch
from
95cbb45
to
45507db
Compare
wagoodman
reviewed
Apr 6, 2023
wagoodman
reviewed
Apr 6, 2023
Signed-off-by: Adrian Wobito <adrian.wobito@gmail.com>
Signed-off-by: Adrian Wobito <adrian.wobito@gmail.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
gnmahanth
pushed a commit
to deepfence/stereoscope
that referenced
this pull request
Jun 15, 2023
* bind file times to metadata Signed-off-by: Adrian Wobito <adrian.wobito@gmail.com> * expose link strategy to walkConditions Signed-off-by: Adrian Wobito <adrian.wobito@gmail.com> * update: test times Signed-off-by: Adrian Wobito <adrian.wobito@gmail.com> * update: link options api Signed-off-by: Adrian Wobito <adrian.wobito@gmail.com> * stub mod time for dynamic tar test fixtures Signed-off-by: Alex Goodman <alex.goodman@anchore.com> * set mtime on tar fixture explicitly Signed-off-by: Alex Goodman <alex.goodman@anchore.com> * always interpret tar header timestamps as UTC Signed-off-by: Alex Goodman <alex.goodman@anchore.com> * interpret all file metadata timestamps as UTC Signed-off-by: Alex Goodman <alex.goodman@anchore.com> --------- Signed-off-by: Adrian Wobito <adrian.wobito@gmail.com> Signed-off-by: Alex Goodman <alex.goodman@anchore.com> Co-authored-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Metadatato hold the fileModTimeand other time data when available.LinkResolutionStrategyto the walk callback via theWalkConditionsThe reason for this PR is I'm using stereoscope to parse the squashedtree to a single tar file, and was required to make these little modifications in order to make that process work.
What do you think?