Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registry certificate verification support #169

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

5p2O5pe25ouT
Copy link
Contributor

I want to help add support for carrying certificates when Grype scans the registry. I have implemented the feature of carrying certificates in the local code through Go Mod Replace and added a certificate configuration to .grypt.yaml file. Currently, I have modified the code on Stereoscope and hope to contribute.

@wagoodman
Copy link
Contributor

This looks like a solid add! I don't want to merge this before taking a look at the proposed changes in syft and grype, can you open up those PRs for a code review as well? (it's ok if all the tests fail due to the go mod replace)

@wagoodman wagoodman self-assigned this Apr 12, 2023
@5p2O5pe25ouT
Copy link
Contributor Author

This looks like a solid add! I don't want to merge this before taking a look at the proposed changes in syft and grype, can you open up those PRs for a code review as well? (it's ok if all the tests fail due to the go mod replace)

Thank you for your affirmation. I will submit pull requests for Syft and Grupe later.

@5p2O5pe25ouT
Copy link
Contributor Author

5p2O5pe25ouT commented Apr 13, 2023

This looks like a solid add! I don't want to merge this before taking a look at the proposed changes in syft and grype, can you open up those PRs for a code review as well? (it's ok if all the tests fail due to the go mod replace)

I submitted pr for syft and grype

syft:
anchore/syft#1734

grype:
anchore/grype#1232

@wagoodman
Copy link
Contributor

@5p2O5pe25ouT we were chatting about this internally, before adding a custom config item in syft and grype are there other workarounds that would be kosher? For instance, adding the cert to your local keychain and leaning on the system certificate pool would be the most straight forward approach. Is there a reason this wouldn't work in your case?

@5p2O5pe25ouT
Copy link
Contributor Author

@wagoodman we are an enterprise serving the military industry. We have strict permission requirements for the system directory during development. We usually do not add the cert to the system certificate pool. So we need to specify the path of the certificate when using it.

@wagoodman
Copy link
Contributor

@5p2O5pe25ouT I can help get this PR (and the syft/grype ones) across the finish line -- one thing that I'll need you to do is to signoff your commits.

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
@wagoodman wagoodman changed the title add registry certificate verification support Add registry certificate verification support Aug 24, 2023
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Copy link
Contributor

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up adding a beefy integration test to ensure it's all wired up alright. Thanks for the contribution @5p2O5pe25ouT , I'll get this in and shepard in the syft and grype PRs you opened for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants