-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: treat manifests with equal digest as single image #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Benchmark Test ResultsBenchmark results from the latest changes vs base branch
|
wagoodman
approved these changes
Sep 19, 2023
gnmahanth
pushed a commit
to deepfence/stereoscope
that referenced
this pull request
Oct 25, 2023
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
gnmahanth
pushed a commit
to deepfence/stereoscope
that referenced
this pull request
Oct 25, 2023
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for anchore/syft#1544
When considering the manifests in the oci directory provider we now check to see if all of the digests are equivalent. If we find that all manifests are the same digest with just different tags then it makes sense to process the tar as a single image for analysis.
Note - this change only affects the directory and tarball provider - we have no such manifest check for the OCI registry provider.
To validate these changes you can go over to syft and use a replace directive using this branch
To generate a local tar with the above conditions simply follow these instructions:
docker-container
driver with buildxapp.tar
Without the branch you should see:
Consuming this branch as the stereoscope dependency you should see: