Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade go-progress #203

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

willmurphyscode
Copy link
Contributor

Previously, a data race was present in go-progress when setting completed on a writer from different goroutines. Pull in an upgrade to go-progress that fixes the race condition.

Previously, a data race was present in go-progress when setting
completed on a writer from different goroutines. Pull in an upgrade to
go-progress that fixes the race condition.

Signed-off-by: Will Murphy <will.murphy@anchore.com>
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch
latest: Pulling from library/ubuntu
tar: Option --mtime: Treating date 'UTC 2019-09-16' as 2019-09-16 00:00:00
goos: linux
goarch: amd64
pkg: github.com/anchore/stereoscope/pkg/file
cpu: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz
ctr: 
           │ ./.tmp/benchmark-38ef190.txt │
           │            sec/op            │
TarIndex-2                   43.05µ ± ∞ ¹
¹ need >= 6 samples for confidence interval at level 0.95

           │ ./.tmp/benchmark-38ef190.txt │
           │             B/op             │
TarIndex-2                  5.560Ki ± ∞ ¹
¹ need >= 6 samples for confidence interval at level 0.95

           │ ./.tmp/benchmark-38ef190.txt │
           │          allocs/op           │
TarIndex-2                    93.00 ± ∞ ¹
¹ need >= 6 samples for confidence interval at level 0.95

pkg: github.com/anchore/stereoscope/test/integration
                                      │ ./.tmp/benchmark-38ef190.txt │
                                      │            sec/op            │
SimpleImage_GetImage/docker-archive-2                   1.351m ± ∞ ¹
SimpleImage_GetImage/podman-2                           19.18m ± ∞ ¹
geomean                                                 5.091m
¹ need >= 6 samples for confidence interval at level 0.95

                                      │ ./.tmp/benchmark-38ef190.txt │
                                      │             B/op             │
SimpleImage_GetImage/docker-archive-2                  327.8Ki ± ∞ ¹
SimpleImage_GetImage/podman-2                          435.2Ki ± ∞ ¹
geomean                                                377.7Ki
¹ need >= 6 samples for confidence interval at level 0.95

                                      │ ./.tmp/benchmark-38ef190.txt │
                                      │          allocs/op           │
SimpleImage_GetImage/docker-archive-2                   2.737k ± ∞ ¹
SimpleImage_GetImage/podman-2                           2.755k ± ∞ ¹
geomean                                                 2.746k
¹ need >= 6 samples for confidence interval at level 0.95

ctr: failed to dial "/run/containerd/containerd.sock": connection error: desc = "transport: error while dialing: dial unix /run/containerd/containerd.sock: connect: permission denied"
                                                   │ ./.tmp/benchmark-38ef190.txt │
                                                   │            sec/op            │
SimpleImage_FetchSquashedContents/docker-archive-2                   17.66µ ± ∞ ¹
SimpleImage_FetchSquashedContents/podman-2                           17.61µ ± ∞ ¹
geomean                                                              17.64µ
¹ need >= 6 samples for confidence interval at level 0.95

                                                   │ ./.tmp/benchmark-38ef190.txt │
                                                   │             B/op             │
SimpleImage_FetchSquashedContents/docker-archive-2                  2.648Ki ± ∞ ¹
SimpleImage_FetchSquashedContents/podman-2                          2.648Ki ± ∞ ¹
geomean                                                             2.648Ki
¹ need >= 6 samples for confidence interval at level 0.95

                                                   │ ./.tmp/benchmark-38ef190.txt │
                                                   │          allocs/op           │
SimpleImage_FetchSquashedContents/docker-archive-2                    21.00 ± ∞ ¹
SimpleImage_FetchSquashedContents/podman-2                            21.00 ± ∞ ¹
geomean                                                               21.00
¹ need >= 6 samples for confidence interval at level 0.95

@willmurphyscode willmurphyscode merged commit bf05af5 into main Sep 25, 2023
6 checks passed
@willmurphyscode willmurphyscode deleted the chore/upgrade-go-progress branch September 25, 2023 13:29
gnmahanth pushed a commit to deepfence/stereoscope that referenced this pull request Oct 25, 2023
Previously, a data race was present in go-progress when setting
completed on a writer from different goroutines. Pull in an upgrade to
go-progress that fixes the race condition.

Signed-off-by: Will Murphy <will.murphy@anchore.com>
gnmahanth pushed a commit to deepfence/stereoscope that referenced this pull request Oct 25, 2023
Previously, a data race was present in go-progress when setting
completed on a writer from different goroutines. Pull in an upgrade to
go-progress that fixes the race condition.

Signed-off-by: Will Murphy <will.murphy@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants