-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade go-progress #203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a data race was present in go-progress when setting completed on a writer from different goroutines. Pull in an upgrade to go-progress that fixes the race condition. Signed-off-by: Will Murphy <will.murphy@anchore.com>
Benchmark Test ResultsBenchmark results from the latest changes vs base branch
|
spiffcs
approved these changes
Sep 25, 2023
gnmahanth
pushed a commit
to deepfence/stereoscope
that referenced
this pull request
Oct 25, 2023
Previously, a data race was present in go-progress when setting completed on a writer from different goroutines. Pull in an upgrade to go-progress that fixes the race condition. Signed-off-by: Will Murphy <will.murphy@anchore.com>
gnmahanth
pushed a commit
to deepfence/stereoscope
that referenced
this pull request
Oct 25, 2023
Previously, a data race was present in go-progress when setting completed on a writer from different goroutines. Pull in an upgrade to go-progress that fixes the race condition. Signed-off-by: Will Murphy <will.murphy@anchore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a data race was present in go-progress when setting completed on a writer from different goroutines. Pull in an upgrade to go-progress that fixes the race condition.