Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic when pulling OCI-packaged helm chart #228

Merged
merged 7 commits into from
Apr 23, 2024
Merged

Fix panic when pulling OCI-packaged helm chart #228

merged 7 commits into from
Apr 23, 2024

Commits on Apr 4, 2024

  1. check that diff IDs exist before dereference 

    Previously, this function would panic when parsing OCI-packaged helm
charts, which apparently have no diff IDs.

Signed-off-by: Will Murphy <will.murphy@anchore.com>
    @willmurphyscode
    willmurphyscode committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    cf9d33a View commit details
    Browse the repository at this point in the history

  2. go mod tidy 

    Signed-off-by: Will Murphy <will.murphy@anchore.com>
    @willmurphyscode
    willmurphyscode committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    1d4dd86 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Only attempt to parse supported layer types 

    Helm charts were causing a panic, but even if parsing the layer metadata
succeeded, an error would be returned. Therefore, just return the error
pre-emptively on unknown layer media types, since this probably fixes
undiscovered bugs similar to the helm chart panic.

Signed-off-by: Will Murphy <will.murphy@anchore.com>
    @willmurphyscode
    willmurphyscode committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    df597a2 View commit details
    Browse the repository at this point in the history

  2. refactor 

    Signed-off-by: Will Murphy <will.murphy@anchore.com>
    @willmurphyscode
    willmurphyscode committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    e57dc6f View commit details
    Browse the repository at this point in the history

  3. clean up todo and unused file 

    Signed-off-by: Will Murphy <will.murphy@anchore.com>
    @willmurphyscode
    willmurphyscode committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    8d70486 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. refactor: address some renames and other feedback 

    Signed-off-by: Will Murphy <will.murphy@anchore.com>
    @willmurphyscode
    willmurphyscode committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    6f8a3fa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:anchore/stereoscope into fix/panic-… 

    …on-oci-helm-chart
    @willmurphyscode
    willmurphyscode committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    d135be8 View commit details
    Browse the repository at this point in the history