-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cataloging root dir takes a very long time #119
Comments
I debugged this, and it isn't that it hangs... it does work. The problem is that it is trying to catalog a whole device, going file by file in the system. On OSX I ran it with
It doesn't seem to me this is a problem |
I've been looking into this more closely. @alfredodeza is right — the issue is that we're performing operations that take a very long time, and this gets exacerbated with additional nested directories, which means that scanning The problemRight now, our To make matters worse, we call A possible solutionParticularly because we need to search for files multiple times within the cataloging process, I'd suggest we somewhat mimic our approach to how we catalog container images, where we start by building an in-memory file tree, and then we use the tree for searches, rather than accessing the disk N times within a single search. For this approach, we could use stereoscope's tree implementation, as well as its |
This has been fixed in #442 |
It seems that
go run main.go dir:///
hangs (even as root). If this operation is not possible we should have better messaging here (though I don't see why this shouldn't work).The text was updated successfully, but these errors were encountered: