Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPM file scanning support #1188

Merged
merged 11 commits into from
Sep 7, 2022

Conversation

kzantow
Copy link
Contributor

@kzantow kzantow commented Aug 31, 2022

This PR adds support for scanning *.rpm files found in the filesystem. Part of this PR renames the RpmdbMetadata type to RpmMetadata, as well as supporting ingesting existing SBOMs with RpmdbMetadata.

Prerequisite for: anchore/grype#570

@kzantow kzantow requested a review from a team August 31, 2022 21:58
@kzantow kzantow force-pushed the add-rpm-file-cataloger branch 2 times, most recently from 548a8fe to cf3b292 Compare September 1, 2022 13:09
Signed-off-by: Keith Zantow <kzantow@gmail.com>
uses: actions/cache@v2.1.3
with:
path: syft/pkg/cataloger/rpm/test-fixtures/rpms
key: ${{ runner.os }}-unit-rpm-cache-${{ hashFiles( 'syft/pkg/cataloger/rpm/test-fixtures/rpms.fingerprint' ) }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be simplified to just hash the Makefile, I've left it this way for consistency

go.mod Show resolved Hide resolved
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow kzantow closed this Sep 7, 2022
@kzantow kzantow reopened this Sep 7, 2022
Copy link
Contributor

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kzantow kzantow merged commit 70db13d into anchore:main Sep 7, 2022
@kzantow kzantow deleted the add-rpm-file-cataloger branch September 7, 2022 18:16
cpendery pushed a commit to cpendery/syft that referenced this pull request Sep 11, 2022
spiffcs pushed a commit that referenced this pull request Sep 19, 2022
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
aiwantaozi pushed a commit to aiwantaozi/syft that referenced this pull request Oct 20, 2022
spiffcs pushed a commit that referenced this pull request Oct 21, 2022
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
spiffcs pushed a commit that referenced this pull request Oct 21, 2022
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants