Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update Makefile to remove old signing arch #1299

Merged
merged 2 commits into from
Oct 31, 2022
Merged

fix: update Makefile to remove old signing arch #1299

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27a9384
fix: update Makefile to remove old signing arch
spiffcs Oct 31, 2022
0d42931
fix: json tags added to previous Metadata addition
spiffcs Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,13 +279,8 @@ snapshot-with-signing: ## Build snapshot release binaries and packages (with dum
echo "dist: $(SNAPSHOTDIR)" > $(TEMPDIR)/goreleaser.yaml
cat .goreleaser.yaml >> $(TEMPDIR)/goreleaser.yaml

rm -f .github/scripts/apple-signing/log/*.txt

# build release snapshots
bash -c "$(SNAPSHOT_CMD) --config $(TEMPDIR)/goreleaser.yaml || (cat .github/scripts/apple-signing/log/*.txt && false)"

# remove the keychain with the trusted self-signed cert automatically
.github/scripts/apple-signing/cleanup.sh
bash -c "$(SNAPSHOT_CMD) --config $(TEMPDIR)/goreleaser.yaml"

snapshot-docker-assets: # Build snapshot images of docker images that will be published on release
$(call title,Building snapshot docker release assets)
Expand Down Expand Up @@ -362,17 +357,12 @@ release: clean-dist CHANGELOG.md
echo "dist: $(DISTDIR)" > $(TEMPDIR)/goreleaser.yaml
cat .goreleaser.yaml >> $(TEMPDIR)/goreleaser.yaml

rm -f .github/scripts/apple-signing/log/*.txt

# note: notarization cannot be done in parallel, thus --parallelism 1
bash -c "\
$(RELEASE_CMD) \
--config $(TEMPDIR)/goreleaser.yaml \
--parallelism 1 \
--release-notes <(cat CHANGELOG.md)\
|| (cat .github/scripts/apple-signing/log/*.txt && false)"

cat .github/scripts/apple-signing/log/*.txt
--release-notes <(cat CHANGELOG.md)

# TODO: turn this into a post-release hook
# upload the version file that supports the application version update check (excluding pre-releases)
Expand Down