npm-aliases: handle aliases for package-lock.json #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikcl
referenced
this pull request
Nov 18, 2022
This PR adds support for npm lockfile version 3, which drops the "dependencies" key and uses "packages" instead. I've refactored the lockfile parser to make the distinction between the versions explicit rather than the implicit behaviour before. It _might_ be worth splitting into separate files at some point, but the logic is so minimal that I haven't done it. Fixes #1203 Signed-off-by: Rob Cresswell <robcresswell@users.noreply.github.com>
Mikcl
force-pushed
the
mikcl/npm-aliases
branch
from
a914fd8
to
0bd18b4
Compare
kzantow
dismissed
their stale review
It looks like there are some checks failing in lint & tests
kzantow
reviewed
Nov 19, 2022
|
Hi @Mikcl could you |
kzantow
approved these changes
Nov 20, 2022
Signed-off-by: mikcl <mikesmikes400@gmail.com>
Mikcl
force-pushed
the
mikcl/npm-aliases
branch
from
86f3957
to
437e267
Compare
kzantow
approved these changes
Nov 20, 2022
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1314
This only addresses npm/
package-lock.jsonaliases.Addresses package-lock.json version 1-3.
the
package.jsonthat thepackage-lock.jsons examples were derived from:https://gist.github.com/Mikcl/aef4d180f4275b66252dca32b6668375#file-package-json