Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle individual cataloger panics #1636

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

kzantow
Copy link
Contributor

@kzantow kzantow commented Mar 1, 2023

This PR handles any panics that occur within individual catalogers, allowing cataloging to continue and an SBOM to be generated.

Fixes #1624

Signed-off-by: Keith Zantow <kzantow@gmail.com>
syft/pkg/cataloger/catalog.go Outdated Show resolved Hide resolved
Copy link
Contributor

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider my earlier comment a nit -- overall this should prevent a lot of issues we see from time to time as we start scaling the amount of catalogers we have in the codebase

Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow kzantow merged commit 24584a4 into anchore:main Mar 1, 2023
@kzantow kzantow deleted the feat/handle-cataloger-panics branch March 1, 2023 15:03
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle cataloger panics
2 participants