Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ruby classifier #1665

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

witchcraze
Copy link
Contributor

@witchcraze witchcraze commented Mar 10, 2023

This PR adds a binary cataloger for ruby

  • 2.x and 3.x
    • use sharedLibraryLookup and fileContentsVersionMatcher
    • test files are under dinamic/ created by Makefile
    • since linked path/file is symbolic, two files (symbolic and true file) are copied in Makefile
  • 1.x
    • use fileContentsVersionMatcher
    • test file is under positive/ with past method

Fixes #1650

Signed-off-by: witchcraze <witchcraze@gmail.com>
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks a lot @witchcraze !

@kzantow kzantow merged commit a81e0c8 into anchore:main Mar 10, 2023
@witchcraze witchcraze deleted the ruby-binary-classifier branch March 10, 2023 14:29
@witchcraze
Copy link
Contributor Author

This is thanks to sophisticated combination of sharedLibraryLookup and Makefile !

spiffcs added a commit to deitch/syft that referenced this pull request Mar 21, 2023
* main: (47 commits)
  Deprecate config.yaml as valid config source; Add unit regression for correct config paths (anchore#1640)
  chore: Update syft bootstrap tools to latest versions. (anchore#1682)
  Update documentation: (anchore#1680)
  chore: Update Stereoscope to 7928713c391e20abaede6a029f4ce37b628a4c8b (anchore#1681)
  fix: reduce logging for bad dpkg lines (anchore#1675)
  fix ruby classifier (anchore#1678)
  feat: add shared dir for easier cleanup (anchore#1676)
  chore(deps): bump github.com/google/go-containerregistry (anchore#1672)
  chore(deps): bump actions/setup-go from 3 to 4 (anchore#1671)
  fix: move defer after error to protect panic case (anchore#1670)
  feat: add argocd, helm, kustomize and kubectl binary classifiers (anchore#1663)
  defer closing file (anchore#1668)
  fix: remove author contributing to javascript CPEs (anchore#1669)
  fix: more python matching support (anchore#1667)
  Update syft bootstrap tools to latest versions. (anchore#1666)
  feat: add ruby classifier (anchore#1665)
  Update syft bootstrap tools to latest versions. (anchore#1658)
  fix: improved Python binary detection (anchore#1648)
  fix: suppress some known incorrect vendor candidates for npm CPEs (anchore#1659)
  fix: sanitize SPDX LicenseRefs (anchore#1657)
  ...

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: witchcraze <witchcraze@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalog ruby binary
2 participants