fix: update cache.fingerprint file to java-builds dir #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
kzantow
approved these changes
Apr 19, 2023
wagoodman
reviewed
Apr 19, 2023
| @@ -36,8 +36,8 @@ jobs: | |||
| - name: Restore Java test-fixture cache | |||
| uses: actions/cache@v3 | |||
| with: | |||
| path: syft/pkg/cataloger/java/test-fixtures/java-builds/packages | |||
| key: ${{ runner.os }}-unit-java-cache-${{ hashFiles( 'syft/pkg/cataloger/java/test-fixtures/java-builds/packages.fingerprint' ) }} | |||
| path: syft/pkg/cataloger/java/test-fixtures/java-builds | |||
There was a problem hiding this comment.
this cache would overwrite what's checked into git (all other locations under java-builds that is outside of packages)
There was a problem hiding this comment.
^ My fault - I thought this is what we wanted where we were checking for any changes under java-builds and rebuilding on changes to those files - thinking more segmenting out the packages folder is the right choice since it keeps the cache smaller, we probably just want to update the makefile to also key off of rebuilding if there are changes to any of the shell scripts *.sh
wagoodman
reviewed
Apr 19, 2023
| find example-* build-* Makefile -type f -exec sha256sum {} \; | sort | tee /dev/stderr | tee $(PKGSDIR).fingerprint | ||
| sha256sum $(PKGSDIR).fingerprint | ||
| .PHONY: cache.fingerprint | ||
| cache.fingerprint: |
There was a problem hiding this comment.
I don't think this fundamentally changed anything -- that is, I think this PR now passes since the fingerprint has changed, but ultimately the cache won't be automatically busted when there is a source change.
spiffcs
added a commit
that referenced
this pull request
Apr 24, 2023
* main: Add sections of interest for Gemfile.lock cataloger (#1749) fix: update cache.fingerprint file to java-builds dir (#1748) Add ALPM Metadata to CYCLONEDX and SPDX output formats (#1747) chore: bump stereoscope to latest version (#1741) chore(deps): update bootstrap tools to latest versions (#1744) chore(deps): bump github.com/docker/docker (#1746) Create consul binary classifier (#1738) chore(deps): update bootstrap tools to latest versions (#1740) Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
validationsworkflow was looking under thepackagesdirectory for a fingerprint file that was not being created correctly. This caused tests to fail on PR that used the older cache after this update was made:This PR syncs the
Makefileforjava-buildfixtures with patterns that exist already in the codebase. It also links these changes into the main Makefile so that CI can correctly validate when the cache needs to be busted.