Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not HTML escape PackageURLs #1782

Merged

Conversation

kzantow
Copy link
Contributor

@kzantow kzantow commented May 4, 2023

sbom-action issue anchore/sbom-action#414 indicates that there is an issue with GitHub accepting PURLs that contain backslashes (even if they are valid JSON escape sequences). This PR adjust the GitHub output to not HTML escape.

Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow kzantow merged commit ddb338d into anchore:main May 5, 2023
9 checks passed
@kzantow kzantow deleted the chore/github-packageurl-escaping branch May 5, 2023 14:08
@willmurphyscode willmurphyscode added the bug Something isn't working label May 5, 2023
spiffcs pushed a commit that referenced this pull request May 10, 2023
Signed-off-by: Keith Zantow <kzantow@gmail.com>
spiffcs added a commit that referenced this pull request May 10, 2023
* main:
  fix: Reduce log spam on unknown relationship type (#1797)
  chore(deps): update bootstrap tools to latest versions (#1807)
  chore(deps): bump golang.org/x/net from 0.9.0 to 0.10.0 (#1802)
  chore(deps): bump github.com/docker/docker (#1795)
  chore(deps): bump github.com/google/go-containerregistry (#1796)
  chore(deps): update bootstrap tools to latest versions (#1792)
  Print package list when extra packages found (#1791)
  chore(deps): update bootstrap tools to latest versions (#1786)
  chore(deps): bump golang.org/x/term from 0.7.0 to 0.8.0 (#1787)
  Update the CPE generation for spring-security-core (#1789)
  chore: do not HTML escape PackageURLs (#1782)
  chore: do not include kernel module cataloger by default (#1784)

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants