Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cataloger improvements for the CLI #1831

Closed
wants to merge 2 commits into from
Closed

Minor cataloger improvements for the CLI #1831

wants to merge 2 commits into from

Commits on May 19, 2023

  1. syft/lib.go: minor improvements to cataloger selection 

    A few minor improvements to the handling of how catalogers are
selected:

- Add --catalogers keyword "ALL" (which is a synonym for "all")
- Add --catalogers keyword "ALL:IMAGE" which selects the default set
  of catalogers used with images
- Add --catalogers keyword "ALL:DIRECTORY" which selects the default
  set of catalogers used with directories
- Add INFO logging messages that indicate which category of catalogers
  were selected
- Add a sanity check: if 0 catalogers are selected, emit an error
- Add DEBUG logging message to show a comma-delimited list of
  the catalogers that were finally selected (suitable for use with the
  --catalogers CLI option)

Also updated the README.md to document the `ALL*` keywords and clarify
a few points about cataloger selection.

Signed-off-by: Jeff Squyres <jeff@squyres.com>
    @jsquyres
    jsquyres committed May 19, 2023
    Configuration menu
    Copy the full SHA
    f62acd7 View commit details
    Browse the repository at this point in the history

  2. syft/lib.go: fail fast if no catalogers selected 

    Move the selection/initialization of the catalogers up before the
initialization of the FileResolver.  This allows failing fast if no
catalogers end up getting selected -- potentially before a (slow)
initialization of the FileResolver.

Signed-off-by: Jeff Squyres <jeff@squyres.com>
    @jsquyres
    jsquyres committed May 19, 2023
    Configuration menu
    Copy the full SHA
    658bf89 View commit details
    Browse the repository at this point in the history