Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support top-level SPDX package and graph #1934

Merged
merged 14 commits into from
Jul 26, 2023

Conversation

kzantow
Copy link
Contributor

@kzantow kzantow commented Jul 12, 2023

This PR adds support to SPDX reading and writing for a top-level element within the SBOM that represents the source which was scanned -- e.g. an image, directory, or file. Additionally, Syft does a best-effort to decode SPDX SBOMs with this information more accurately into Syft's internal data model.

Fixes #1661
Fixes #1241

…ing what was scanned image/file/dir

Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Copy link

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @kzantow for this PR! This is 💯 , have a couple comments/questions.

Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Copy link
Contributor

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job 🙌

@kzantow kzantow merged commit 9480f10 into anchore:main Jul 26, 2023
9 checks passed
@kzantow kzantow deleted the feat/spdx-source-element branch July 26, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants