-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support top-level SPDX package and graph #1934
Merged
kzantow
merged 14 commits into
anchore:main
from
kzantow-anchore:feat/spdx-source-element
Jul 26, 2023
Merged
feat: support top-level SPDX package and graph #1934
kzantow
merged 14 commits into
anchore:main
from
kzantow-anchore:feat/spdx-source-element
Jul 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing what was scanned image/file/dir Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
wagoodman
reviewed
Jul 13, 2023
wagoodman
reviewed
Jul 13, 2023
wagoodman
reviewed
Jul 13, 2023
wagoodman
reviewed
Jul 13, 2023
wagoodman
reviewed
Jul 13, 2023
wagoodman
reviewed
Jul 13, 2023
wagoodman
reviewed
Jul 13, 2023
lumjjb
reviewed
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @kzantow for this PR! This is 💯 , have a couple comments/questions.
syft/formats/spdxjson/test-fixtures/snapshot/TestSPDXRelationshipOrder.golden
Show resolved
Hide resolved
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
wagoodman
reviewed
Jul 26, 2023
wagoodman
reviewed
Jul 26, 2023
wagoodman
reviewed
Jul 26, 2023
syft/formats/spdxtagvalue/test-fixtures/snapshot/TestSPDXJSONSPDXIDs.golden
Show resolved
Hide resolved
wagoodman
reviewed
Jul 26, 2023
Signed-off-by: Keith Zantow <kzantow@gmail.com>
wagoodman
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job 🙌
This was referenced Jul 31, 2023
Closed
This was referenced Aug 15, 2023
Merged
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to SPDX reading and writing for a top-level element within the SBOM that represents the source which was scanned -- e.g. an image, directory, or file. Additionally, Syft does a best-effort to decode SPDX SBOMs with this information more accurately into Syft's internal data model.
Fixes #1661
Fixes #1241