Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to latest commit in tools-golang #1969

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Conversation

spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Jul 27, 2023

Summary

This bumps syft to the latest version of the spdx/tools-golang library which has a fix for decoding issues surrounding the originator field in spdx json

Follow up on an issue reported over in grype anchore/grype#1306

I can bump this to an official release when it comes out, but wanted to get this fix in if we're looking to cut a new release this PM.

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@github-actions
Copy link

github-actions bot commented Jul 27, 2023

Benchmark Test Results

Benchmark results from the latest changes vs base branch
goos: linux%0Agoarch: amd64%0Apkg: github.com/anchore/syft/test/integration%0Acpu: Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz%0A                                                              │ ./.tmp/benchmark-81dce22.txt │%0A                                                              │            sec/op            │%0AImagePackageCatalogers/alpmdb-cataloger-2                                       11.99m ±  1%25%0AImagePackageCatalogers/apkdb-cataloger-2                                        678.4µ ±  1%25%0AImagePackageCatalogers/binary-cataloger-2                                       205.7µ ±  0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                       556.5µ ±  4%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                   21.39µ ±  1%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                             94.36µ ±  0%25%0AImagePackageCatalogers/java-cataloger-2                                         13.69m ±  2%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                         93.90µ ±  1%25%0AImagePackageCatalogers/javascript-package-cataloger-2                           357.3µ ±  1%25%0AImagePackageCatalogers/nix-store-cataloger-2                                    266.2µ ±  1%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                       786.0µ ±  3%25%0AImagePackageCatalogers/portage-cataloger-2                                      431.8µ ± 26%25%0AImagePackageCatalogers/python-package-cataloger-2                               3.265m ±  1%25%0AImagePackageCatalogers/r-package-cataloger-2                                    184.0µ ±  1%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                       496.7µ ±  1%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                 854.5µ ±  2%25%0AImagePackageCatalogers/sbom-cataloger-2                                         118.3µ ±  0%25%0Ageomean                                                                         466.6µ%0A%0A                                                              │ ./.tmp/benchmark-81dce22.txt │%0A                                                              │             B/op             │%0AImagePackageCatalogers/alpmdb-cataloger-2                                       5.116Mi ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                        204.7Ki ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                       30.25Ki ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                       168.8Ki ± 0%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                   3.696Ki ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                             9.906Ki ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                         2.843Mi ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                         8.594Ki ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                           94.32Ki ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                    49.14Ki ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                       186.4Ki ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                      119.9Ki ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                               1.003Mi ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                    53.29Ki ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                       181.0Ki ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                 144.1Ki ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                         14.21Ki ± 0%25%0Ageomean                                                                         100.3Ki%0A%0A                                                              │ ./.tmp/benchmark-81dce22.txt │%0A                                                              │          allocs/op           │%0AImagePackageCatalogers/alpmdb-cataloger-2                                        87.74k ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                         4.181k ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                         830.0 ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                        3.002k ± 0%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                     132.0 ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                               281.0 ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                          40.19k ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                           228.0 ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                            1.342k ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                      895.0 ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                        4.079k ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                       2.268k ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                                16.44k ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                      929.0 ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                        3.989k ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                  2.447k ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                           394.0 ± 0%25%0Ageomean                                                                          2.052k

@spiffcs spiffcs marked this pull request as ready for review July 27, 2023 17:27
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants