Set precedence for root options #1987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AidanDelaney
force-pushed
the
config-file-env
branch
from
485880b
to
dac9bbf
Compare
Allows RootOptions to be set using command line flags or alternatively through an environmental variable. Maintains the priority order described in Application.LoadAllValues. Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
AidanDelaney
force-pushed
the
config-file-env
branch
from
dac9bbf
to
a850b5b
Compare
|
Thanks for this PR @AidanDelaney -- I'm currently working on a much larger change for configuration that fixes, among other things, the precedence issues. I assume this isn't a blocking issue for you, would you be okay to wait a couple weeks for the changes to make their way in and close this PR in the meantime? (If you're curious to see what the type of change is, we have a couple helper libraries that have been applied to quill and chronicle already, and Syft is next, actively being worked on) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows RootOptions to be set using command line flags or alternatively through an environmental variable. Maintains the priority order described in Application.LoadAllValues.
Fixes #1986