Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set precedence for root options #1987

Closed
wants to merge 1 commit into from

Conversation

AidanDelaney
Copy link
Contributor

Allows RootOptions to be set using command line flags or alternatively through an environmental variable. Maintains the priority order described in Application.LoadAllValues.

Fixes #1986

Allows RootOptions to be set using command line flags or alternatively
through an environmental variable.  Maintains the priority order
described in Application.LoadAllValues.

Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
@kzantow
Copy link
Contributor

kzantow commented Aug 2, 2023

Thanks for this PR @AidanDelaney -- I'm currently working on a much larger change for configuration that fixes, among other things, the precedence issues. I assume this isn't a blocking issue for you, would you be okay to wait a couple weeks for the changes to make their way in and close this PR in the meantime?

(If you're curious to see what the type of change is, we have a couple helper libraries that have been applied to quill and chronicle already, and Syft is next, actively being worked on)

@AidanDelaney
Copy link
Contributor Author

@kzantow Thanks for the context. I'll have a look at clio for my own projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SYFT_CONFIG environment variable not supported
2 participants